optimize: SDK bundle size by ~100kb

safe-global · May 11, 2023 · 7db6ff1 · 7db6ff1
1 parent 0cf10f7
commit 7db6ff1
Show file tree

Hide file tree

Showing 19 changed files with 348 additions and 72 deletions.
diff --git a/packages/safe-apps-sdk/dist/package.json b/packages/safe-apps-sdk/dist/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@safe-global/safe-apps-sdk",
-    "version": "7.10.1",
+    "version": "7.11.0",
     "description": "SDK developed to integrate third-party apps with Safe app.",
     "main": "dist/src/index.js",
     "typings": "dist/src/index.d.ts",
@@ -24,7 +24,7 @@
     "license": "MIT",
     "dependencies": {
         "@safe-global/safe-gateway-typescript-sdk": "^3.5.3",
-        "ethers": "^5.7.2"
+        "viem": "0.3.21"
     },
     "devDependencies": {
         "rimraf": "^3.0.2"

diff --git a/packages/safe-apps-sdk/dist/src/safe/index.js b/packages/safe-apps-sdk/dist/src/safe/index.js
diff --git a/packages/safe-apps-sdk/dist/src/safe/index.js.map b/packages/safe-apps-sdk/dist/src/safe/index.js.map
diff --git a/packages/safe-apps-sdk/dist/src/safe/signatures.d.ts b/packages/safe-apps-sdk/dist/src/safe/signatures.d.ts
@@ -1,6 +1,3 @@
-import { ethers } from 'ethers';
 declare const MAGIC_VALUE = "0x1626ba7e";
 declare const MAGIC_VALUE_BYTES = "0x20c13b0b";
-declare const EIP_1271_INTERFACE: ethers.utils.Interface;
-declare const EIP_1271_BYTES_INTERFACE: ethers.utils.Interface;
-export { EIP_1271_INTERFACE, EIP_1271_BYTES_INTERFACE, MAGIC_VALUE, MAGIC_VALUE_BYTES };
+export { MAGIC_VALUE, MAGIC_VALUE_BYTES };
diff --git a/packages/safe-apps-sdk/dist/src/safe/signatures.js b/packages/safe-apps-sdk/dist/src/safe/signatures.js
diff --git a/packages/safe-apps-sdk/dist/src/safe/signatures.js.map b/packages/safe-apps-sdk/dist/src/safe/signatures.js.map
diff --git a/packages/safe-apps-sdk/dist/src/setupTests.d.ts b/packages/safe-apps-sdk/dist/src/setupTests.d.ts
@@ -0,0 +1 @@
+export {};
diff --git a/packages/safe-apps-sdk/dist/src/setupTests.js b/packages/safe-apps-sdk/dist/src/setupTests.js
diff --git a/packages/safe-apps-sdk/dist/src/setupTests.js.map b/packages/safe-apps-sdk/dist/src/setupTests.js.map
diff --git a/packages/safe-apps-sdk/dist/src/types/sdk.d.ts b/packages/safe-apps-sdk/dist/src/types/sdk.d.ts
@@ -1,5 +1,4 @@
 import { ChainInfo as _ChainInfo } from '@safe-global/safe-gateway-typescript-sdk';
-import { BigNumberish, BytesLike } from 'ethers';
 export type ChainInfo = Pick<_ChainInfo, 'chainName' | 'chainId' | 'shortName' | 'nativeCurrency' | 'blockExplorerUriTemplate'>;
 export { NativeCurrency } from '@safe-global/safe-gateway-typescript-sdk';
 export type BaseTransaction = {
@@ -26,9 +25,11 @@ export type SignMessageParams = {
 export interface TypedDataDomain {
     name?: string;
     version?: string;
-    chainId?: BigNumberish;
+    chainId?: string | number | bigint | {
+        toNumber: () => number;
+    };
     verifyingContract?: string;
-    salt?: BytesLike;
+    salt?: string;
 }
 export interface TypedDataTypes {
     name: string;
@@ -41,6 +42,7 @@ export type EIP712TypedData = {
     domain: TypedDataDomain;
     types: TypedMessageTypes;
     message: Record<string, any>;
+    primaryType?: string;
 };
 export type SignTypedMessageParams = {
     typedData: EIP712TypedData;

diff --git a/packages/safe-apps-sdk/jest-environment-jsdom.js b/packages/safe-apps-sdk/jest-environment-jsdom.js
@@ -0,0 +1,19 @@
+// https://github.com/paralleldrive/cuid2/issues/44#issuecomment-1531731695
+const { TextEncoder, TextDecoder } = require('util');
+const { default: $JSDOMEnvironment, TestEnvironment } = require('jest-environment-jsdom');
+
+Object.defineProperty(exports, '__esModule', {
+  value: true,
+});
+
+class JSDOMEnvironment extends $JSDOMEnvironment {
+  constructor(...args) {
+    const { global } = super(...args);
+    global.Uint8Array = Uint8Array;
+    if (!global.TextEncoder) global.TextEncoder = TextEncoder;
+    if (!global.TextDecoder) global.TextDecoder = TextDecoder;
+  }
+}
+
+exports.default = JSDOMEnvironment;
+exports.TestEnvironment = TestEnvironment === $JSDOMEnvironment ? JSDOMEnvironment : TestEnvironment;
diff --git a/packages/safe-apps-sdk/jest.config.js b/packages/safe-apps-sdk/jest.config.js
@@ -4,5 +4,5 @@ module.exports = {
   moduleDirectories: ['node_modules', 'src'],
   roots: ['src'],
   verbose: true,
-  testEnvironment: 'jsdom',
+  testEnvironment: './jest-environment-jsdom.js',
 };
diff --git a/packages/safe-apps-sdk/package.json b/packages/safe-apps-sdk/package.json
@@ -24,7 +24,7 @@
   "license": "MIT",
   "dependencies": {
     "@safe-global/safe-gateway-typescript-sdk": "^3.5.3",
-    "ethers": "^5.7.2"
+    "viem": "0.3.21"
   },
   "devDependencies": {
     "rimraf": "^3.0.2"