Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade @testing-library/react to the version supporting react 17 #402

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Nov 25, 2022

This PR:
Fixes #400 by downgrading the @testing-library/react library by one major version, so it is compatible with the version of react library we're using.

To test:

npx create-react-app my-safe-app --template file:../path-to-template

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2022

🦋 Changeset detected

Latest commit: 545c205

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@gnosis.pm/cra-template-safe-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@mmv08 mmv08 linked an issue Nov 25, 2022 that may be closed by this pull request
@mmv08 mmv08 merged commit a3ca045 into development Nov 25, 2022
@mmv08 mmv08 deleted the bug/cra-template-peerdeps branch November 25, 2022 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential Cra-Template Issues
2 participants