Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Cra-Template Issues #400

Closed
asharma13524 opened this issue Nov 22, 2022 · 2 comments · Fixed by #402
Closed

Potential Cra-Template Issues #400

asharma13524 opened this issue Nov 22, 2022 · 2 comments · Fixed by #402
Assignees

Comments

@asharma13524
Copy link

asharma13524 commented Nov 22, 2022

I am continuously getting the following below error when running

npx create-react-app drain-safe --template @gnosis.pm/cra-template-safe-app

I believe it has to do with the version here https://github.com/safe-global/safe-apps-sdk/blob/master/packages/cra-template-safe-app/template.json#L15.

see testing-library/react-testing-library#1121 (comment) for example.

Any idea what might be going on here? Thanks.

npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^18.0.0" from @testing-library/[email protected]
npm ERR! node_modules/@testing-library/react
npm ERR!   dev @testing-library/react@"^13.4.0" from the root project

Curious what I may be missing on my end, thanks!

Have attempted to move down to [email protected] and [email protected] to no avail.


Update: I have gotten the command to not error out. For anyone looking to get this up and running for the time being:

the following fails:
npx create-react-app drain-safe --template @gnosis.pm/[email protected]

and the following works:

  1. npx create-react-app drain-safe --template @gnosis.pm/[email protected].
    Again, I believe there are some broken fonts in this version but the command does not error out.

  2. Remove related font code here https://github.com/safe-global/safe-apps-sdk/pull/388/files#diff-68c12a430f865c61eee3d09fe68f486c048af196cf7a2b347f0c5105c94f01c8L1-L2.

  3. npm start (or yarn)

@asharma13524
Copy link
Author

thanks

@mmv08
Copy link
Member

mmv08 commented Nov 29, 2022

@asharma13524 thanks for a well written report 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants