Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe Apps Provider: Add xdai chain network id #129

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Apr 8, 2021

This PR:

In the future we will make the core sdk return the chain id, removing the need to add an id per network

@mmv08 mmv08 requested a review from germartinez April 8, 2021 08:43
@mmv08 mmv08 changed the base branch from master to development April 8, 2021 08:44
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@mmv08 mmv08 merged commit 4d876b9 into development Apr 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2021
@mmv08 mmv08 deleted the feature/add-xdai-chain-id branch April 15, 2021 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for xDai Gnosis Safes
2 participants