Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for xDai Gnosis Safes #128

Closed
dan13ram opened this issue Apr 6, 2021 · 1 comment · Fixed by #129
Closed

Add support for xDai Gnosis Safes #128

dan13ram opened this issue Apr 6, 2021 · 1 comment · Fixed by #129

Comments

@dan13ram
Copy link

dan13ram commented Apr 6, 2021

Hi team,
I noticed that the provider for xDai Gnosis Safes does not return chainId
It is returned as undefined as per https://github.com/gnosis/safe-apps-sdk/blob/4fb096ac61b125cdbb7680f65ab990534f9bb0c3/packages/safe-apps-provider/src/provider.ts#L33

I'm not sure what other places needs changes, but please do the needful for supporting xDai Gnosis Safes =)
@mmv08 mmv08 mentioned this issue Apr 8, 2021
Merged
@mmv08
Copy link
Member

mmv08 commented Apr 8, 2021

should be added in provider version 0.2.4

@mmv08 mmv08 closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Safe Apps Provider: Add xdai chain network id safe-global/safe-apps-sdk
2 participants
@dan13ram @mmv08