Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use create2 to deploy merkle lockup campaigns #355

Merged
merged 12 commits into from
Jun 18, 2024
Merged

feat: use create2 to deploy merkle lockup campaigns #355

merged 12 commits into from
Jun 18, 2024

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Jun 17, 2024 •
edited
Loading

@smol-ninja smol-ninja marked this pull request as draft June 17, 2024 22:13
@smol-ninja smol-ninja marked this pull request as ready for review June 18, 2024 08:04
@smol-ninja smol-ninja mentioned this pull request Jun 18, 2024
Closed
3 tasks
PaulRBerg
PaulRBerg approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback below, already addressed in my commits.

src/SablierV2MerkleLockupFactory.sol Outdated Show resolved Hide resolved
src/SablierV2MerkleLockupFactory.sol Outdated Show resolved Hide resolved
src/SablierV2MerkleLockupFactory.sol Outdated Show resolved Hide resolved
@smol-ninja smol-ninja mentioned this pull request Jun 18, 2024
Merged
2 tasks
andreivladbrg
andreivladbrg reviewed Jun 18, 2024
View reviewed changes
src/SablierV2MerkleLT.sol Outdated Show resolved Hide resolved
src/SablierV2MerkleLockupFactory.sol Outdated Show resolved Hide resolved
@PaulRBerg
Copy link
Member

OK, looks good to me now

andreivladbrg
andreivladbrg approved these changes Jun 18, 2024
View reviewed changes
src/SablierV2MerkleLT.sol Show resolved Hide resolved
@smol-ninja smol-ninja merged commit 46ca3bc into staging Jun 18, 2024
7 checks passed
@smol-ninja smol-ninja deleted the create2 branch June 18, 2024 20:09
@andreivladbrg andreivladbrg mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulRBerg PaulRBerg PaulRBerg approved these changes

@andreivladbrg andreivladbrg andreivladbrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smol-ninja @PaulRBerg @andreivladbrg