fix: use percentages in schedule #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
fix/unlock-amounts
branch
2 times, most recently
from
09fc56e to
525ab17
Compare
test: update tests accordingly
andreivladbrg
force-pushed
the
fix/unlock-amounts
branch
2 times, most recently
from
5ef8e4d to
abe3961
Compare
andreivladbrg
force-pushed
the
fix/unlock-amounts
branch
from
abe3961 to
ab98653
Compare
andreivladbrg
commented
Dec 20, 2024
|
In SablierMerkleLL's constructor, why are you not verifying that the sum of percentages <= 100%? If it exceeds, campaign creator will not know until the first claim is made, which will then fail. |
due to this: https://github.com/cantinasec/review-sablier-3/issues/1 |
smol-ninja
approved these changes
Dec 21, 2024
smol-ninja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
Note: unlike tranches percentages, here, we don't need to ensure that the unlock amounts sum equals the claim amount