Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add saber-plugin-search #366

Merged
merged 12 commits into from
Aug 22, 2019

Conversation

krmax44
Copy link
Contributor

@krmax44 krmax44 commented Aug 17, 2019

Summary

saber-plugin-local-search adds a hyper-fast, easy to integrate and highly customizable search to your app. See README for more.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Original issue: saberland/saber-theme-tailsaw#5

Published PR with canary version:

Canary Versions

  • extract-sfc-blocks@0.0.3-canary.366.524f251.0
  • create-blog@0.2.8-canary.366.524f251.0
  • create-site@0.3.2-canary.366.524f251.0
  • saber-highlight-css@0.1.1-canary.366.524f251.0
  • saber-highlighter-prism@0.3.2-canary.366.524f251.0
  • saber-log@0.2.1-canary.366.524f251.0
  • saber-markdown@0.1.1-canary.366.524f251.0
  • saber-plugin-feed@0.4.1-canary.366.524f251.0
  • saber-plugin-git-modification-time@0.1.1-canary.366.524f251.0
  • saber-plugin-google-analytics@0.1.1-canary.366.524f251.0
  • saber-plugin-image@0.1.1-canary.366.524f251.0
  • saber-plugin-meta-redirect@0.1.1-canary.366.524f251.0
  • saber-plugin-netlify-redirect@0.1.1-canary.366.524f251.0
  • saber-plugin-prismjs@0.2.2-canary.366.524f251.0
  • saber-plugin-pwa@0.4.1-canary.366.524f251.0
  • saber-plugin-query-posts@0.4.1-canary.366.524f251.0
  • saber-plugin-search@0.0.2-canary.366.524f251.0
  • saber-plugin-transformer-html@0.1.1-canary.366.524f251.0
  • saber-plugin-transformer-pug@0.1.1-canary.366.524f251.0
  • saber-utils@0.2.1-canary.366.524f251.0
  • saber@0.7.1-canary.366.524f251.0

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@netlify
Copy link

netlify bot commented Aug 17, 2019

Deploy preview for saber ready!

Built with commit a9583b2

https://deploy-preview-366--saber.netlify.com

Verified

This commit was signed with the committer’s verified signature.
@krmax44
Copy link
Contributor Author

krmax44 commented Aug 17, 2019

Here's a demo where you can see it in action: https://deploy-preview-31--saber-theme-tailsaw.netlify.com/

@krmax44 krmax44 requested a review from a team August 19, 2019 07:50
krmax44 and others added 2 commits August 19, 2019 17:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: Koyuki (EGOIST) <0x142857@gmail.com>

Verified

This commit was signed with the committer’s verified signature.
@egoist
Copy link
Collaborator

egoist commented Aug 19, 2019

what about adding an option to allow more search strategies? e.g. adapter: 'local' | 'algolia' | ImplementYourOwn.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@krmax44
Copy link
Contributor Author

krmax44 commented Aug 21, 2019

I unfortunately can't fully test it at the moment, but I'll try to do it when I'm back home in a couple of days. If someone of you wants to experiment in the meantime, feel free to do so :)

@egoist egoist changed the title feat: saber-plugin-local-search feat: saber-plugin-search Aug 22, 2019
@egoist egoist requested a review from a team August 22, 2019 07:23
@egoist egoist changed the title feat: saber-plugin-search feat: add saber-plugin-search Aug 22, 2019
@krmax44
Copy link
Contributor Author

krmax44 commented Aug 22, 2019

Updated preview with Tailsaw: https://5d5e79095fbf530008ae7f60--saber-theme-tailsaw.netlify.com/

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
krmax44 added a commit to krmax44/saber that referenced this pull request Aug 22, 2019
* feat: saber-plugin-local-search

* fix: only add valid pages

* use global public url

Co-Authored-By: Koyuki (EGOIST) <0x142857@gmail.com>

* shorten syntax

* rename plugin to `saber-plugin-search`

* feat: add multiple adapter support

* make it more low-level

* strip html tags

* Add LICENSE

* tweaks
@krmax44
Copy link
Contributor Author

krmax44 commented Aug 22, 2019

It's in master but the PR is not marked as merged 🤔

@egoist
Copy link
Collaborator

egoist commented Aug 22, 2019

@krmax44: It's in master but the PR is not marked as merged 🤔

Yes GitHub is was screwed 😅

image

@egoist egoist merged commit aaf2d63 into saberland:master Aug 22, 2019
@krmax44
Copy link
Contributor Author

krmax44 commented Aug 22, 2019

Alright, lol. I'll wait on the next package publish so the canary flag gets removed, then I'll merge in the Tailsaw search PR.

@egoist
Copy link
Collaborator

egoist commented Aug 22, 2019

Published saber-plugin-search@0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants