-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add local search, closes #5 #31
Conversation
What about including saber-plugin-search in this theme by default? So users don't have to install and configure it themselves. |
While they wouldn't have to download it, they would still have to configure it though, right? saberland/saber#160 We could pull off the workaround saberland/saber#160 (comment) to register it maybe, but then the user doesn't have control, right? 🤔 |
If we go with the old way we should only enable search in this theme when |
What about adding it as a dependency and extending the docs to: theme: tailsaw
plugins:
- saber-plugin-query-posts
- saber-plugin-prismjs
- saber-plugin-critical
- saber-plugin-search |
Implemented. |
Anything else or ready to merge? |
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Requires saberland/saber#366 to be merged in first.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor