Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search #5

Closed
diomed opened this issue May 2, 2019 · 9 comments
Closed

search #5

diomed opened this issue May 2, 2019 · 9 comments

Comments

@diomed
Copy link
Contributor

diomed commented May 2, 2019

Issuehunt badges

what about integrating search?

[algolia, maybe?]

or fusesearch as in original template


IssueHunt Summary

krmax44 krmax44 has been rewarded.

Backers (Total: $200.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@krmax44
Copy link
Collaborator

krmax44 commented May 2, 2019

Would be great to create this functionality as a Saber plugin!

@diomed
Copy link
Contributor Author

diomed commented May 2, 2019

yeah , I asked for this and egoist said it was theme feature.

welp :|

@diomed
Copy link
Contributor Author

diomed commented May 2, 2019

you can see it in Saber's #general room on Discord

@egoist
Copy link
Contributor

egoist commented May 2, 2019

for algolia search, it should be implemented by the theme.

for local search, we can create a plugin like this: https://github.com/christian-fei/Simple-Jekyll-Search

@egoist
Copy link
Contributor

egoist commented Jun 21, 2019

We can split this into two steps:

  1. Implement a search UI. i.e. a search bar that allows you to type some keywords and get feedback
  2. The underlying searching API. (a local JSON file or Algolia DocSearch)

@krmax44
Copy link
Collaborator

krmax44 commented Jun 21, 2019

@egoist the JSON file of which could be generated by a plugin

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jun 21, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 21, 2019

@issuehunt has funded $200.00 to this issue.


@krmax44 krmax44 self-assigned this Aug 17, 2019
@krmax44 krmax44 closed this as completed in 2ed60ef Sep 9, 2019
krmax44 added a commit that referenced this issue Sep 9, 2019
@egoist
Copy link
Contributor

egoist commented Sep 9, 2019

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@egoist egoist added the released label Sep 9, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 9, 2019

@krmax44 has rewarded $180.00 to @krmax44. See it on IssueHunt

  • 💰 Total deposit: $200.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $20.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants