feat(Post): Implement asset cover feature #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doesn't work on the demo |
|
Woops, forgot to include demo. See latest change |
|
Bump @egoist |
egoist
reviewed
Oct 17, 2019
| <div class="post-title"> | ||
| {{ post.attributes.title }} | ||
| <saber-link class="post post-card" :to="post.attributes.permalink"> | ||
| <div v-if="post.attributes.assets" class="post-cover"> |
There was a problem hiding this comment.
actually post.attributes.assets defaults to {} 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31
This adds a few things, assets cover image on posts, post, and home page. With home and posts list it shows the image cropped but centred.
Although not implemented, there's preparation to support landscape type with a new themeConfig
coverLayoutthat defaults tominimal.Screenshots
Home page
Posts list
Post detail
cc @Quaj @saltysugar
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor