Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show post cover image on home/post/posts page #31

Closed
egoist opened this issue Jun 25, 2019 · 12 comments · Fixed by #124
Closed

Show post cover image on home/post/posts page #31

egoist opened this issue Jun 25, 2019 · 12 comments · Fixed by #124
Assignees
Labels
enhancement New feature or request 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt

Comments

@egoist
Copy link
Collaborator

egoist commented Jun 25, 2019

Issuehunt badges

Use the assets.cover attribute.


IssueHunt Summary

spytec spytec has been rewarded.

Backers (Total: $100.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@egoist egoist added the enhancement New feature or request label Jun 25, 2019
@egoist egoist changed the title Show cover image on home/post/posts page Show post cover image on home/post/posts page Jun 25, 2019
@egoist egoist self-assigned this Jun 25, 2019
@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jun 25, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 25, 2019

@issuehunt has funded $100.00 to this issue.


@egoist egoist added the pending label Jun 25, 2019
@Venefilyn
Copy link
Contributor

I was wondering if this should be covering the whole top, as 100% width. Then have a transparent circle where the back to home button is

@Venefilyn
Copy link
Contributor

Venefilyn commented Jun 27, 2019

Thought of two concepts:

1:
image

which is using a div above the div.wrap element in post.vue, styling being:

height: 350px;
background: url("https://www.bing.com/th?id=OHR.RootBridge_ROW5832767622_1920x1080.jpg&rf=LaDigue_1920x1080.jpg&pid=hp") center center;
background-size: cover;

as well as --bg color for the button's background instead of transparent.

2:
image

Same as above, but with div.wrap moved up and -100px and div.column.is-6.is-offset-3 set to background-color: var(--bg). Though I'd probably want to increase the padding on the column here

@Venefilyn
Copy link
Contributor

@egoist thoughts on the above?

@ducan-ne
Copy link

is this done?

@Venefilyn
Copy link
Contributor

It is not, @Quaj do you have a preference of one of the two I posted or would you go a different route?

@ducan-ne
Copy link

ducan-ne commented Aug 28, 2019

absolutely i thinks you misunderstand egoist mean
his issue too short, i think egoist's mean is a option to create a cover for a specify post
something like this

---
title: Dear CO
layout: post
date: 2019-08-28
hero: ./images/hero.jpg
tags:
  - hello

@Venefilyn
Copy link
Contributor

Venefilyn commented Aug 28, 2019

Saber already has functionality for cover posts using assets.cover, all that is needed is displaying it. This ticket is primarily for the design on how this should look on home, posts, and post.

Home and Posts isn't something I drafted up, but could look something like this:
image

@egoist
Copy link
Collaborator Author

egoist commented Sep 25, 2019

@SpyTec For post page I prefer a minimal approach like: https://leo.im/2017/canary

image

Maybe this could be an option for the theme: coverLayout: 'minimal' | 'landscape'

For home and posts page, your draft looks good.

@egoist egoist removed the pending label Sep 25, 2019
@saltysugar
Copy link

@SpyTec Are you going to work on this?

@Venefilyn
Copy link
Contributor

Venefilyn commented Sep 25, 2019

I like the coverLayout option. I think that would be a good addition

@saltysugar I will work on it this weekend. But feel free to implement it before that

@issuehunt-oss
Copy link

issuehunt-oss bot commented Mar 24, 2020

@egoist has rewarded $70.00 to @spytec. See it on IssueHunt

  • 💰 Total deposit: $100.00
  • 🎉 Repository reward(20%): $20.00
  • 🔧 Service fee(10%): $10.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt
Projects
None yet
4 participants