Add module-info.java, fixes #2 #3
Conversation
There was a problem hiding this comment.
Thanks for taking a look! The current code (Version 1.2.0) is already building with and using Java 9 features (namely Set::of, InputStream::transferTo, InputStream::readNBytes, InputStream::readAllBytes and Arrays::equals), so I'm not sure how to proceed. I see two possibilities:
- Remove the Java 9 usage from the current code.
- Make another PR against the last released version that was Java 8 (Version 1.0.2, that's also the version used by fastexcel). Then do a point release (1.0.3?), then merge the changes back into master.
|
Oh, damm! I haven't pushed my commit for Java 8 compatibility I've made a year ago 🤦 |
|
Haha, always good to be prepared! I'll take a look. |
- Bump test dependency + plugin versions - Set project.build.sourceEncoding to fix build warning - Fix FileListTest when run as a module - Bump Travis JDK version to oraclejdk9 - Set scm.url without property reference so it works on search.maven.org
|
@rzymek I rebased onto master and switched back to target Java 8. Please take another look. Note: The project still has to be compiled with Java 9+ so the compiler understands the module-info. If building with Java 8 is needed, we could use https://github.com/moditect/moditect (generates module-info.class by ASM magic). |
I also took the liberty to do the following things, please tell me if I should revert some of them:
The
--add-opensargs for surefire are needed because JUnit reflectively calls the package private test methods, and that's not allowed when we are a module. An alternative would be to make every test class / method public, but that will probably just annoy future developers while providing little gain.