Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module-info.java #2

Open
zimmi opened this issue Apr 14, 2021 · 1 comment
Open

Add module-info.java #2

zimmi opened this issue Apr 14, 2021 · 1 comment

Comments

@zimmi
Copy link

zimmi commented Apr 14, 2021

Hi!

I'd like to use fastexcel in a modularized application, so it would be fantastic if this project could add a module-info.java file.
Since it already requires Java 9, this should be as simple as putting a file like this into the package root:

module com.github.rzymek.opczip {
    exports com.github.rzymek.opczip;
    exports com.github.rzymek.opczip.reader;
    exports com.github.rzymek.opczip.reader.ordered;
    exports com.github.rzymek.opczip.reader.skipping;
}

Open questions:

  1. Should every package be exported?
  2. Are you open for a PR doing this? :)

I see that fastexcel itself has a baseline of Java 8, but there is a straightforward way to add a module-info.java there as well: https://maven.apache.org/plugins/maven-compiler-plugin/examples/module-info.html

@rzymek
Copy link
Owner

rzymek commented Apr 14, 2021

Sure! I'm totally open for PRs!
I think every package should be exported.

We can have module-info.java and still have Java 8 compatibility, so that's not a problem.

zimmi added a commit to zimmi/opczip that referenced this issue Apr 14, 2021
- Bump test dependency + plugin versions
- Set project.build.sourceEncoding to fix build warning
- Fix FileListTest when run as a module
- Bump Travis JDK version to oraclejdk9
- Set scm.url without property reference so it works on search.maven.org
zimmi added a commit to zimmi/opczip that referenced this issue Apr 19, 2021
- Bump test dependency + plugin versions
- Set project.build.sourceEncoding to fix build warning
- Fix FileListTest when run as a module
- Bump Travis JDK version to oraclejdk9
- Set scm.url without property reference so it works on search.maven.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants