Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the official Puppet icon as a custom icon #652

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

dhollinger
Copy link
Contributor

@dhollinger dhollinger commented Aug 13, 2021

Description

Added the official icon for the Puppet DSL to the nerd fonts.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

How should this be manually tested?

  • Patch a font of your choice with font-patcher. Be sure to include the Seti/Custom icons
  • Install the font to your system
  • Open the bin/scripts/lib/l_seti.sh file and make sure the icon appears correctly at the i_custom_puppet location

Any background context you can provide?

Many of the icons out there, such as devicons and nvim-webdev-icons still utilize the a beaker as the icon for Puppet code manifests, which was changed several years ago to the current icon.

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Screenshot from 2021-08-13 12-59-23
Screenshot from 2021-08-13 12-59-43

@dhollinger
Copy link
Contributor Author

@ryanoasis any idea if/when this could get merged (or if you have any feedback)?

@dhollinger
Copy link
Contributor Author

@ryanoasis Is there anything else I need to do to get this merged?

@ryanoasis
Copy link
Owner

Sorry for the delay.

It looks like you got everything correct and added it to the original set by extending by 1. Just want to quickly pull it down.

Plan to tackle these open PRs this weekend but can't promise.

@ryanoasis ryanoasis merged commit be0069c into ryanoasis:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants