Update the puppet icon(s) #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyazdani42
approved these changes
Aug 14, 2021
|
should we merge this now or wait for the related PR to be merged ? |
|
I would wait until the related PR is merged. Otherwise, users will end up with a Horizontal line/rule instead of an icon. |
|
@kyazdani42 Just to keep this from falling into the nether - still waiting on nerdfonts to merge the related PR. Just pinged @ryanoasis again on it. He appears to have looked at the PR and thumbs upped it, but not review or merge yet. |
|
I replied. Trying to catch up. Thanks! |
dhollinger
force-pushed
the
puppet_icon
branch
from
0fc97b0
to
69e6e12
Compare
|
@kyazdani42 ryanoasis/nerd-fonts#652 was merged last month. I fixed the merge conflicts and this can be merged anytime you are ready |
kyazdani42
reviewed
Dec 20, 2021
lua/nvim-web-devicons.lua
Outdated
| @@ -1373,4 +1377,3 @@ return { | |||
| has_loaded = function() return loaded end, | |||
| get_icons = function() return icons end, | |||
| set_up_highlights = set_up_highlights, | |||
| } | |||
There was a problem hiding this comment.
just remove that diff and we'll be good to go then :)
There was a problem hiding this comment.
Should be fixed now.
dhollinger
force-pushed
the
puppet_icon
branch
from
69e6e12
to
11fa2eb
Compare
dhollinger
force-pushed
the
puppet_icon
branch
from
11fa2eb
to
9019d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Puppet icon and color and added the same for Puppet .epp files
This is dependent on the following PR in ryanoasis/nerd-fonts: ryanoasis/nerd-fonts#652