Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out dim tags potentially needs duplicated logic #116

Closed
albertz opened this issue Feb 18, 2022 · 1 comment
Closed

Out dim tags potentially needs duplicated logic #116

albertz opened this issue Feb 18, 2022 · 1 comment
Milestone

Comments

@albertz
Copy link
Member

albertz commented Feb 18, 2022

#17 (comment) lead us to have out_spatial_dim as an optional arg to many functions and modules, e.g. Conv.

When this is not passed (also see #115), then some default dim tag is created. When this is a dynamic dim, this is fine and no extra logic is needed. When this is static, we need to know the resulting dim in advance, and basically need to duplicate the logic from RETURNN, e.g. ConvLayer.calc_out_dim.

This issue is also on pure RETURNN side, and reported here: rwth-i6/returnn#955

However, we probably need to have some changes here on returnn-common side as well.

@albertz
Copy link
Member Author

albertz commented Mar 3, 2022

rwth-i6/returnn#955 is fixed now via rwth-i6/returnn#974.

I think this solves the issue already here.

@albertz albertz closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant