Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unspecified out dim #974

Merged
merged 29 commits into from
Mar 3, 2022
Merged

Allow unspecified out dim #974

merged 29 commits into from
Mar 3, 2022

Conversation

albertz
Copy link
Member

@albertz albertz commented Mar 1, 2022 •
edited
Loading

Fix #955 for most relevant layers, as an extension to #597.

  • ConvLayer
  • PoolLayer
  • TransposedConvLayer
  • WindowLayer
  • PadLayer
  • ResizeLayer
  • PrefixInTimeLayer
  • PostfixInTimeLayer
  • SliceLayer
  • SliceNdLayer
  • MergeDimsLayer
  • SplitDimsLayer (nothing needs to be done I think)
  • UnflattenNdLayer (nothing needs to be done I think)
  • RepeatLayer
  • TimeChunkingLayer (I think nothing needs to be done)
  • RemoveLayer (I think nothing needs to be done)
  • RecLayer (I think nothing needs to be done)
  • EditDistanceTableLayer (already done)
  • MaskedComputationLayer (I think nothing needs to be done)
  • CumConcatLayer (nothing needs to be done)
  • RangeFromLengthLayer (already done)
  • RangeLayer (already done)
  • ScatterNdLayer (nothing needs to be done)
  • ReduceOutLayer
  • StackLayer
  • SplitLayer (I think nothing needs to be done)
  • TileLayer
  • ConcatLayer (already done)
  • GatingLayer

albertz and others added 28 commits March 1, 2022 17:55
@albertz
test_MergeDimsLayer_unspecified_out_dim
fe31ae3 
#955
rwth-i6/returnn_common#117
@albertz
Dim declare_same_as, set when is_dim_known
4bae259 
#955
@albertz
MergeDimsLayer, declare_same_as on out_dim
0a06418 
#955
@albertz
ConvLayer and co, declare_same_as on out_spatial_dims
b001688 
#955
@albertz
WindowLayer, declare_same_as on out_spatial_dim, window_dim
b1bbcb6 
#955
@albertz
WindowLayer, cleanup
723dcc7
@albertz
TransposedConvLayer, declare_same_as on out_spatial_dims, cleanup
11b9fef 
#955
@albertz
PadLayer, declare_same_as on out_dims, cleanup
f41d795 
#955
@albertz
WindowLayer, small warning fix
8e939e3
@albertz
Dim, dyn_size, try to complete
285a7d5
@albertz
Dim, complete_dyn_size, make sure it is a tensor
b30a013
@albertz
Dim, complete_dyn_size, make sure it is positive
2953a8b
@albertz
ConvLayer calc_out_dim, nicer
e1e68d1
@albertz
Dim complete_dyn_size, small fix for missing batch info
dacb25b
@albertz
ConvLayer, cleanup and fix set_output_dim_tags
92ba17d
@albertz
ResizeLayer, declare_same_as on out_dim, cleanup
48285ec 
#955
@albertz
ResizeLayer, fixes
1836177
@albertz
PrefixInTimeLayer, declare_same_as on out_dim, cleanup
9bb81e3 
#955
@albertz
PostfixInTimeLayer, declare_same_as on out_dim, cleanup
e01b32a 
#955
@albertz
SliceLayer, declare_same_as on out_dim, cleanup
7d2955c 
#955
@albertz
Dim complete_dyn_size, small fix for is_negative check
75b2313
@albertz
SliceLayer, small fix
09e5bdd
@albertz
SliceNdLayer, declare_same_as on out_spatial_dim
43fd127 
#955
@albertz
RepeatLayer, declare_same_as on out_dim
7d3fc59 
#955
@albertz
ReduceOutLayer, declare_same_as on out_dim
0f9cc61 
#955
@albertz
StackLayer, declare_same_as on out_spatial_dim
5137a82 
#955
@albertz
TileLayer, declare_same_as on out_dims
02548e4 
#955
@albertz
GatingLayer, declare_same_as on out_dim
6a16a95 
#955
@albertz albertz marked this pull request as ready for review March 3, 2022 15:02
@albertz albertz requested a review from a team as a code owner March 3, 2022 15:02
@albertz albertz merged commit 921cfef into master Mar 3, 2022
@albertz albertz deleted the albert-out-dim-tags-specify-955 branch March 3, 2022 15:34
This was referenced Mar 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettelkasten Zettelkasten Awaiting requested review from Zettelkasten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specified out dim tags potentially needs duplicated logic
1 participant
@albertz