Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update alpine docker tag to v3.17 #128

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 9, 2022

Mend Renovate

This PR contains the following updates:

Package Update Change
alpine minor 3.16 -> 3.17

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title chore(deps): update alpine docker tag to v3.17 Update alpine Docker tag to v3.17 Dec 17, 2022
@renovate renovate bot changed the title Update alpine Docker tag to v3.17 chore(deps): update alpine docker tag to v3.17 Dec 17, 2022
@renovate renovate bot force-pushed the renovate/alpine-3.x branch 2 times, most recently from 4adcf2f to ec4d5c6 Compare January 28, 2023 02:55
@renovate
Copy link
Contributor Author

renovate bot commented Jan 29, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@strophy
Copy link
Collaborator

strophy commented Jan 30, 2023

This PR contains an update to our base image to Alpine 3.17, which in turn bumps protoc from 3.18 to 3.21.

The JavaScript plugin was moved out to a separate repository in protobuf 3.21 (announcement), so a new protoc-gen-js plugin is now needed to generate JS code. Since this does not yet exist in Alpine (tracking issue here), and the plugin is not yet available in npm like it is for TypeScript, and the released plugin binaries depend on GNU libc instead of musl libc, we can build the plugin for musl using bazel (which also needs to be built, due to lack of arm support in Bazel 5.2.0+ for Alpine), which then supports both arm64 and amd64 arch in Alpine 3.17.

Alternatively, glibc linked binaries are available in the JavaScript plugin release, but this requires installation of libstdc++ in the Alpine target image. We could do that for greater simplicity and faster build times instead, but I expect build times will benefit from caching due to the structure of the Dockerfile.

@rvolosatovs please review :)

Copy link
Owner

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Really good job, thanks!

@rvolosatovs rvolosatovs merged commit 9d9f0ef into main Jan 30, 2023
@rvolosatovs rvolosatovs deleted the renovate/alpine-3.x branch January 30, 2023 08:27
@strophy strophy mentioned this pull request Mar 12, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants