Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS support on arm64 #179

Closed
1 task done
strophy opened this issue Mar 12, 2023 · 1 comment
Closed
1 task done

JS support on arm64 #179

strophy opened this issue Mar 12, 2023 · 1 comment

Comments

@strophy
Copy link
Collaborator

strophy commented Mar 12, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

#128 bumped the protoc version from 3.18 to 3.21.

The JavaScript plugin was moved out to a separate repository in protobuf 3.21 (announcement), so a new protoc-gen-js plugin is now needed to generate JS code. Since this does not yet exist in Alpine (tracking issue here), and the plugin is not yet available in npm like it is for TypeScript, and the released plugin binaries depend on GNU libc instead of musl libc, we need to build the plugin ourself using Bazel.

Bazel 5.2.0+ is required to build, but we cannot build it under Alpine due to this bug. I plan to resolve this with Alpine directly, since we really shouldn't be building Bazel itself if not necessary. Alternatively, we could install libstd++ in the target container, but let's see if any of the other blockers get resolved first.

Acceptance Criteria

Working protoc_gen_js build under Alpine.

Suggestions for a technical implementation

See above

@strophy strophy changed the title [Feature]: ARM support for protoc_gen_js JS support on arm64 Mar 12, 2023
@strophy
Copy link
Collaborator Author

strophy commented Jul 8, 2024

Resolved in #349 (fix) and #351 (enable test)

@strophy strophy closed this as completed Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant