Reload DPI on PropertyChange #3222
Conversation
Supersedes #2874, fixes #1228 Signed-off-by: John Nunley <[email protected]>
notgull
added
DS - x11
C - waiting on maintainer
|
This is amazing! Thank you 😍 |
How would this be done? |
Cursors are server side on X11, so it's up to it to resize the cursor, not winit. |
Signed-off-by: John Nunley <[email protected]>
|
The error here appears to be spurious |
| for (_, window) in wt.windows.borrow().iter() { | ||
| if let Some(window) = window.upgrade() { | ||
| window.refresh_dpi_for_monitor( | ||
| &new_monitor, | ||
| maybe_prev_scale_factor, | ||
| &mut *callback, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think you can move upgrade part into iterator by doing filter_map? So it'll be even less nesting.
| if let Some(prev_list) = prev_list { | ||
| let new_list = wt | ||
| .xconn | ||
| .available_monitors() | ||
| .expect("Failed to get monitor list"); |
There was a problem hiding this comment.
This really demands early return with match.
kchibisov
removed
the
C - waiting on maintainer
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Supersedes #2874, fixes #1228
CHANGELOG.mdif knowledge of this change could be valuable to users