x11: reload dpi on PropertyChangeEvent #2874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frebib
force-pushed
the
x11-dpi-reload
branch
4 times, most recently
from
95b5d9a to
7f5df6f
Compare
This change allows X11 windows to receive ScaleFactorChanged events when using Xft.dpi via the root window PropertyChange event. Subscribe to PropertyChange events on the root window, and reload all available monitors when an XA_RESOURCE_MANAGER change is received. This is a very heavy handed approach to this problem, but it was the least intrustive way I could find to make it work with my limited skill. Load XResources directly via XGetTextProperty on every get_xft_dpi call as XResourceManagerString returns stale cached data and does not reload for the lifetime of the window (?) Fixes: rust-windowing#1228 Signed-off-by: Joe Groocock <[email protected]>
|
I can rewrite this for the new XCB backend if needed. |
|
@notgull that would be amazing if you could 😍 this was only ever a hack anyway |
|
@notgull beep |
notgull
added a commit
that referenced
this pull request
Nov 12, 2023
Supersedes #2874, fixes #1228 Signed-off-by: John Nunley <[email protected]>
|
My bad, I forgot to close this after I merged #3222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows X11 windows to receive ScaleFactorChanged events when using Xft.dpi via the root window PropertyChange event.
Subscribe to PropertyChange events on the root window, and reload all available monitors when an XA_RESOURCE_MANAGER change is received. This is a very heavy handed approach to this problem, but it was the least intrustive way I could find to make it work with my limited skill. Load XResources directly via XGetTextProperty on every get_xft_dpi call as XResourceManagerString returns stale cached data and does not reload for the lifetime of the window (?)
Fixes: #1228
CHANGELOG.mdif knowledge of this change could be valuable to usersFull disclosure- I have no idea what I'm doing. This has worked for me for the past few years with no issues, but the code is probably bad. I've never written Rust in my life, but I figured this was a starting point