Add fast case (no-op case) for into_dimensionality and into_dyn #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case has most impact for IxDyn, the benchmark for const dims is unchanged (it was already fast).
This method was simply not special cased for `IxDyn`.
bluss
force-pushed
the
faster-into-dimensionality
branch
from
ef115c6
to
83cf00d
Compare
bluss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a no-cloning or no-allocation case for
IxDyntoIxDynin this method; there is no change to other conversions - they were already good, benchmarks show.into_dynwas improved for the dyn -> dyn case by just adding a missing special caseIxDyn::into_dynmethod.Fixes #905