Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast path to into_dimensionality #905

Closed
bluss opened this issue Feb 2, 2021 · 0 comments · Fixed by #906
Closed

Add fast path to into_dimensionality #905

bluss opened this issue Feb 2, 2021 · 0 comments · Fixed by #906
Assignees

Comments

@bluss
Copy link
Member

bluss commented Feb 2, 2021

There are (generic) situations where we use into_dimensionality::<D>() as a no-op, we just don't have a proof in the type system that the two dimensions are equal. The method should have a TypeId (or equivalent based on a new Dimension method) based fast-path that basically transmutes input dimensions to output dimensions, to avoid copying and make the (generated) code simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant