Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ndk 0.4.0, ndk-glue 0.4.0, ndk-build 0.4.1 #166

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented Jul 30, 2021

Fixes #164

ndk-glue 0.3.1 depends on a breaking change in the NDK, and can only be released if that's released under 0.4.0.


Draft: I'm not sure if this is the right thing to do, or if we should aim for ndk-glue 0.4.0. ndk-glue exposes quite a few NDK symbols in its public API, and running cargo update in a crate that uses both (very likely) they'll end up with duplicate crates and incompatible types unless they manually update to ndk 0.4 (which is possibly, but unexpected sudden breakage because semver allows going from 0.3.0 to 0.3.1 without issues).


ndk-glue depends on a breaking change in the NDK, and can only be released if that's released under 0.4.0. This, in turn, causes ndk-glue to need a minor bump too despite no other breaking changes, as NDK symbols are used in its public API.

Note that ndk-glue 0.3.1 was never properly released as the ndk update requirement outlined above caused an adequate publishing failure.

@MarijnS95 MarijnS95 marked this pull request as draft July 30, 2021 13:51
Copy link
Contributor

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a new cargo-apk version too? would love getting the ci fixed too while we're making releases

@MarijnS95
Copy link
Member Author

MarijnS95 commented Jul 31, 2021

@dvc94ch it looks like the last change to the cargo-apk/ subfolder was its 0.8.0 release; anything you're missing in particular? What CI breakage are you referring to?

@dvc94ch
Copy link
Contributor

dvc94ch commented Jul 31, 2021

I guess ndk-build is enough if it's only a patch release. Looking for this commit:

d21e51f

@MarijnS95
Copy link
Member Author

@dvc94ch Right, yes, a patch release should be enough!

ndk-build/CHANGELOG.md Outdated Show resolved Hide resolved
@MarijnS95
Copy link
Member Author

@dvc94ch Any comment on whether ndk-glue needs to perform a minor instead of patch release, when relying on a minor release of the ndk?

@dvc94ch
Copy link
Contributor

dvc94ch commented Aug 1, 2021

it's the safe thing to do. generally I release minor versions whenever I upgrade a dependency. there may be cases were it isn't strictly necessary. but in this case we are leaking types from ndk in fn native_activity() for example, so it is necessary.

ndk-glue depends on a breaking change in the NDK, and can only be
released if that's released under 0.4.0.  This, in turn, causes ndk-glue
to need a minor bump too despite no other breaking changes, as NDK
symbols are used in its public API.

Note that ndk-glue 0.3.1 was never properly released as the ndk update
requirement outlined above caused an adequate publishing failure.
@MarijnS95 MarijnS95 changed the title Release ndk 0.4.0 and actually release ndk-glue 0.3.1 Release ndk 0.4.0, ndk-glue 0.4.0, ndk-build 0.4.1 Aug 2, 2021
@MarijnS95 MarijnS95 marked this pull request as ready for review August 2, 2021 09:08
@MarijnS95
Copy link
Member Author

@dvc94ch Yep, thanks for confirming. Should all be set now, would you mind reviewing once more before we merge this?

@iamralpht I'm not sure if we can fully fix #164 as winit takes quite some time to release new versions, unless we set up the proper infrastructure to perform non-breaking backport patch releases and actually get ndk-glue 0.3.1 out the door without depending on ndk 0.4.0.

@MarijnS95 MarijnS95 requested a review from dvc94ch August 2, 2021 09:12
Copy link
Contributor

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@@ -1,6 +1,6 @@
[package]
name = "ndk-build"
version = "0.4.0"
version = "0.4.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked, a patch is fine

@@ -1,6 +1,6 @@
[package]
name = "ndk-glue"
version = "0.3.1"
version = "0.4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is safe in any case and we already discussed it

@@ -1,6 +1,6 @@
[package]
name = "ndk"
version = "0.3.0"
version = "0.4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is clear from the changelog

@MarijnS95
Copy link
Member Author

@dvc94ch Thanks for checking! Let's get this merged now, I'll be able to monitor the crate during the day in case something happens after all.

@MarijnS95 MarijnS95 merged commit 074eb06 into rust-mobile:master Aug 3, 2021
@MarijnS95 MarijnS95 deleted the ndk-release branch August 3, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New release with threading fixes?
2 participants