Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release with threading fixes? #164

Closed
iamralpht opened this issue Jul 29, 2021 · 3 comments · Fixed by #165 or #166
Closed

New release with threading fixes? #164

iamralpht opened this issue Jul 29, 2021 · 3 comments · Fixed by #165 or #166

Comments

@iamralpht
Copy link

iamralpht commented Jul 29, 2021

Would it be possible to make a new release on crates.io (and then update winit)? The recent threading fixes in ndk_glue seem like very important improvements. If it would help to have a PR that bumps the versions then I can create one.

@MarijnS95
Copy link
Member

MarijnS95 commented Jul 29, 2021

Looks like the changes weren't added to CHANGELOG.md, hence went unnoticed for a while. We'll try to release them as patch version with #165 so that winit doesn't need to change anything as per semver (but building with -Zminimal-versions could use a bump to 0.3.1, fwiw).

@iamralpht
Copy link
Author

Wow, thanks so much for doing this so quickly!

@MarijnS95
Copy link
Member

@iamralpht No problem, I'm actually quite ashamed it took as long as it did as we're usually releasing changes on time.

Unfortunately the crate failed to publish as I misjudged a dependency on the ndk crate, see #165 (comment). I'll re-evaluate and hopefully have the release up later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants