Add support for fish shell and continue adding support for non-posix compliant shells. #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMonZ
approved these changes
Sep 30, 2022
|
I had to shelve this project for a while due to technical difficulties with my previous setup, but I should be able to get back to this now. |
social-anthrax
force-pushed
the
arty/fish_shell
branch
from
0c96a45
to
f00f9ba
Compare
No additional information is displayed during installation, so it might be worth mentioning where it is being added to path
social-anthrax
force-pushed
the
arty/fish_shell
branch
from
f00f9ba
to
1a1e440
Compare
|
Possibly superceded by #3108. |
|
Closing in favor of #3108. Thanks a lot for helping out anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #478.
This further contributes to Jubilee Young's efforts to add support for non-posix compliant shells by adding
add_to_pathandremove_from_pathmethods to the UnixShell trait. This removes the bulk of code from unix.rs.As part of this, support for fish shell is also added by writing to $HOME/.config/fish/conf.d/cargo.fish as recommended by fish shell issue 3170.
Any recommendations for further tests and changes to how the fish path should be handled are welcome.