Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically setup env on fish shell #3021

Closed
xrisk opened this issue Jul 4, 2022 · 4 comments
Closed

Automatically setup env on fish shell #3021

xrisk opened this issue Jul 4, 2022 · 4 comments

Comments

@xrisk
Copy link

xrisk commented Jul 4, 2022

Problem you are trying to solve

The installer currently sets up the .profile, .bash_profile and .zshenv files to source "$HOME/.cargo/env”. I would like something similar to be supported for the fish shell as well.

Solution you'd like

Append a call to "$HOME/.cargo/env-fish” (for example) in the users config.fish

Notes

No response

@xrisk xrisk changed the title Support automatically adding path to fish shell Automatically setup env on fish shell Jul 4, 2022
@johnmatthiggins
Copy link

I would really like to implement this. I was looking through the code base and I found this reference to non-posix shells. Does a potential solution need to be discussed first or should I just take a swing at it?

@kinnison
Copy link
Contributor

@johnmatthiggins If you think you can come up with a clean way to integrate for fish then please have a swing at it. you can ask questions here, or on the #wg-rustup channel on the rust-lang discord and we'll be happy to help.

@kinnison
Copy link
Contributor

There is another issue #478 about fish support, and a draft pr #2995 which you might be able to join forces on.

@rbtcollins
Copy link
Contributor

Marking as duplicate with #478 - I don't think these are different enough to warrant different conversations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants