Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump rustc-ap crates to v686 #4495

Merged
merged 1 commit into from
Oct 27, 2020
Merged

deps: bump rustc-ap crates to v686 #4495

merged 1 commit into from
Oct 27, 2020

Conversation

ghedo
Copy link
Contributor

@ghedo ghedo commented Oct 27, 2020

This seems to be required to fix rustfmt build on latest nightly. See rust-lang/rust#78341 (comment).

@ghedo
Copy link
Contributor Author

ghedo commented Oct 27, 2020

Turns out I was a bit too optimistic... I'm going to look into what changes are required here, but if anyone has a better idea on how to make this work, feel free to take over.

@calebcartwright
Copy link
Member

Turns out I was a bit too optimistic... I'm going to look into what changes are required here, but if anyone has a better idea on how to make this work, feel free to take over.

😄 Yes sometimes these are pleasantly uneventful, and other times it's a major effort to incorporate all the upstream rustc changes

@ghedo
Copy link
Contributor Author

ghedo commented Oct 27, 2020

I think I figured it out, let's see if the builds now pass.

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants