Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt no longer builds after rust-lang/rust#78334 #78341

Closed
rust-highfive opened this issue Oct 25, 2020 · 6 comments · Fixed by #78775
Closed

rustfmt no longer builds after rust-lang/rust#78334 #78341

rust-highfive opened this issue Oct 25, 2020 · 6 comments · Fixed by #78775
Assignees
@calebcartwright @topecongiro
Labels
A-rustfmt Area: Rustfmt C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #78334, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @jonas-schievink, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-rustfmt Area: Rustfmt C-bug Category: This is a bug. labels Oct 25, 2020
@calebcartwright
Copy link
Member

calebcartwright commented Oct 25, 2020 •
edited
Loading

We'll need a new rustc-ap version that contains the rustc_data_structures updates from #76614

At a minimum the steps will include:

Note that the rustc-ap bumps in racer and rustfmt can be done in parallel (step 2's), the other tasks all have to be sequenced

Edit - had to restart a few steps due to subsequent changes merged in rustc

@calebcartwright calebcartwright mentioned this issue Oct 25, 2020
Closed
This was referenced Oct 27, 2020
Merged
Merged
@ghedo
Copy link
Contributor

ghedo commented Oct 27, 2020

Racer PR racer-rust/racer#1140
rustfmt PR rust-lang/rustfmt#4495

@ghedo ghedo mentioned this issue Oct 28, 2020
Merged
@ghedo
Copy link
Contributor

ghedo commented Oct 29, 2020

I just realized that we also need the rusfmt fix for the 1.4.23 branch as well, so I made rust-lang/rustfmt#4501 for that.

@calebcartwright calebcartwright mentioned this issue Oct 30, 2020
Merged
@calebcartwright
Copy link
Member

Blocked on #78549 for the time being

@Nadrieril Nadrieril mentioned this issue Oct 30, 2020
Closed
@Aaron1011
Copy link
Member

#78549 has now been fixed

@calebcartwright calebcartwright mentioned this issue Nov 3, 2020
Merged
@ghedo ghedo mentioned this issue Nov 5, 2020
Merged
@ghedo
Copy link
Contributor

ghedo commented Nov 5, 2020

I just made #78775 which should hopefully be the last piece I think. Not sure if I did it right though, so please take a look.

This was referenced Nov 6, 2020
Merged
Merged
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 8, 2020
@m-ou-se
Rollup merge of rust-lang#78775 - ghedo:bump-rustfmt-rls, r=Mark-Simu…
04859e5 
…lacrum

Bump Rustfmt and RLS

Should hopefully fix rust-lang#78341 and fix rust-lang#78340.
@bors bors closed this as completed in bff2e46 Nov 8, 2020
@jyn514 jyn514 mentioned this issue Nov 11, 2020
Closed
Mark-Simulacrum pushed a commit to Mark-Simulacrum/rust that referenced this issue Nov 15, 2020
@ghedo @Mark-Simulacrum
Bump Rustfmt and RLS
9876548 
Should hopefully fix rust-lang#78341 and rust-lang#78340.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calebcartwright calebcartwright

@topecongiro topecongiro

Labels
A-rustfmt Area: Rustfmt C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Rustfmt and RLS
Circumvent rust build regression Nadrieril/rustfmt
5 participants
@ghedo @Aaron1011 @rust-highfive @calebcartwright @topecongiro