Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly implement checked binops #6

Closed
bjorn3 opened this issue Aug 8, 2018 · 2 comments
Closed

Properly implement checked binops #6

bjorn3 opened this issue Aug 8, 2018 · 2 comments
Labels
C-bug Category: This is a bug.
Milestone
MVP

Comments

@bjorn3
Copy link
Member

bjorn3 commented Aug 8, 2018 •
edited
Loading

They are currently considered as always succeeding.

Edit: #646 implemented add and sub overflow checks.
@bjorn3 bjorn3 added this to the MVP milestone Aug 8, 2018
@bjorn3 bjorn3 removed this from the MVP milestone Nov 16, 2018
@bjorn3 bjorn3 mentioned this issue Mar 23, 2019
Open
@bjorn3 bjorn3 mentioned this issue Jul 26, 2019
Merged
@bjorn3 bjorn3 added this to the MVP milestone Jul 26, 2019
@bjorn3
Copy link
Member Author

bjorn3 commented Jul 26, 2019

Added to MVP milestone, as making checked binops always succeeding causes hard to debug crashes at various places of the standard library.

@bjorn3 bjorn3 added the C-bug Category: This is a bug. label Jul 26, 2019
bjorn3 added a commit that referenced this issue Sep 14, 2019
@bjorn3
Implement shl and shr overflow checks
8f12b87 
cc #6
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 14, 2019

Only multiplication is remaining.

@bjorn3 bjorn3 mentioned this issue Nov 24, 2019
Closed
@bjorn3 bjorn3 closed this as completed in 5f54cc7 Jun 20, 2020
@asaadmohammed74 asaadmohammed74 mentioned this issue Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug.
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@bjorn3