Make rustc test suite pass #381
Labels
C-bug
Category: This is a bug.
Comments
|
Ignoring all emscripten ignored tests brings failed down to 525. Emscripten doesn't support threading, u/i128 and inline asm just like cg_clif. |
|
Filled #388 for multithreading support. |
|
And down to 510 thanks to 2ce5387. |
|
I write a script to categorize the failing tests: Not categorized |
|
1f00b7b fixed several tests. |
|
I reduced the macro_rules! t {
($a:expr, $b:expr) => { assert_eq!($a, $b) }
}
pub fn main() {
t!(format!("{:.*}", 4, "aaaaaaaaaaaaaaaaaa"), "aaaa"); // with -Zopt-level=2
// thread 'main' panicked at 'assertion failed: `(left == right)`
// left: `"aaaaaaaaaaaaaaaaaa"`,
// right: `"aaaa"`', rust/src/test/run-pass/ifmt.rs:6:5
t!(format!("{:.3e}", 1.2345e6f64), "1.234e6"); // with -Zopt-level=1
// thread 'main' panicked at 'assertion failed: noborrow', sysroot_src/src/libcore/num/bignum.rs:481:1
} |
|
|
This comment has been minimized.
This comment has been minimized.
|
With rust-lang/rust#58902 fixed, error count is down to 112: Not catagorized |
|
Smaller repro for #![feature(core_private_bignum)]
extern crate core;
use core::num::bignum::Big32x40 as Big;
fn main() {
let mut mant = Big::from_u64(0x278106_24dd2f1a);
let scale = Big::from_u64(0x200000_00000000);
mant.sub(&scale);
} |
|
I think |
|
0df3b41: 108 -> 103 failed |
|
Now 112: Not categorized |
|
I just wanted to pop on here and say that all the work you've done here in this repo with rustc and another codegen backend is truly incredible and you're super awesome and I hope you feel super amazing about what you've accomplished in such a short time, even if you stop right now it's totally amazing. That's all :) |
|
Thanks you very much @m4b! |
|
Now 111 (from 128) by d7274ac: Not categorizedI accidentially made the assumption that the second component of a pair was stored directly after the first, which is not true when the size of the first component is smaller than the alignment of the second. |
|
Now 85 as of bdf23c0: Not categorized |
|
With the recent merge of the |
|
Down to 91: |
This comment has been minimized.
This comment has been minimized.
|
@bjorn3 Wow, that was a huge jump! Thank you for working on this project! |
|
It seems like I had ignored too much tests. Currently trying again with less ignored tests. |
|
With old filter it gives 74 failures, with new (and fixed) one from 2d5a0b8 it gives 57: |
|
@bjorn3 Thank you for all of the work you've put into this project! Do you have a patreon, paypal, or some other method available so that those who are interested can donate and thank you for your work? |
|
Thanks @vultix for this nice comment! I really appreciate it. I just made a liberapay page: https://liberapay.com/bjorn3/. |
|
Thanks a lot for all donations! |
Closed
|
I just ran the test suite again. This time I ignored all tests that should give an error, as many give a different error or even panic with cg_clif. I also removed most of the tests that require unwinding support or other unimplemented things. After looking through the results, I found several bugs. Several tests also get a stack overflow. (More stack usage due to less optimizations?) I haven't had the time to look at all failures yet. |
|
The number of failed and ignored tests keeps going down! Thank you for your hard work! |
|
When compiletest sees that it previously successfully tested a test, it will automatically mark that test as ignored. This means that there are 4331 passed tests and 32 failed tests. The huge decrease in passed tests and a part of the decrease in failed tests is because this time I ignored all compile-fail tests by removing them from the |
|
Except for tests that either should error or require unimplemented features, the only failing |
|
Thanks to #1068 82 tests which depended on the previously unimplemented struct argument passing for the SystemV abi are now passing. |
|
Removed from the MVP milestone as enough tests pass to be usable in most cases. |
Merged
bjorn3
added a commit
that referenced
this issue
Jan 4, 2023
bjorn3
added a commit
that referenced
this issue
Jan 4, 2023
bjorn3
added a commit
that referenced
this issue
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cc #247
I got a branch to test it at https://github.com/bjorn3/rustc_codegen_cranelift/tree/wip_test_rustc_testsuite.
Excluding the following tests:
src/test/run-pass/{asm-*,abi-*,extern/,panic-runtime/,panics/,unsized-locals/,proc-macro/,threads-sendsync/,thinlto/,simd/}The following
run-passtests fail:Note: those 805 ignored are tests passed when I ran it previous time.
The most common runtime errors are:
The text was updated successfully, but these errors were encountered: