Streamline lint checking #99888
Merged
Streamline lint checking #99888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're not used by rustc or clippy.
Because the default is empty and it's never overridden. This means `walk_ident` can also be removed, because it does nothing.
They're not used by rustc or clippy.
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 30, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#99227 (Fix thumbv4t-none-eabi frame pointer setting) - rust-lang#99518 (Let-else: break out scopes when a let-else pattern fails to match) - rust-lang#99671 (Suggest dereferencing index when trying to use a reference of usize as index) - rust-lang#99831 (Add Fuchsia platform support documentation) - rust-lang#99881 (fix ICE when computing codegen_fn_attrs on closure with non-fn parent) - rust-lang#99888 (Streamline lint checking) - rust-lang#99891 (Adjust an expr span to account for macros) - rust-lang#99904 (Cleanup html whitespace) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The early (AST) and late (HIR) lint checkers have a number of functions that aren't used by rustc or clippy. Might as well remove them -- it's not like there's a canonical API here, as shown by the ad hoc use of
check_foo/check_foo_postcombinations.r? @cjgillot