Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fuchsia platform support documentation #99831

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

djkoloski
Copy link
Contributor

This documentation contains instructions for building and running binaries on Fuchsia using its provided SDK.

@rust-highfive
Copy link
Collaborator

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2022
Comment on lines 202 to 209
And archive it into a single file:

```sh
${SDK_PATH}/tools/${ARCH}/pm -o hello_fuchsia -m package/hello_fuchsia.manifest archive
```

This will produce `hello_fuchsia/hello_fuchsia-0.far` which is the package in
the Fuchsia Archive Format (FAR).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an alternative to this step, you can produce an output manifest by passing --output-package-manifest $out_pkg_manifest to pm build and then publish that with pm publish --repo repo -lp -f <(echo "$out_pkg_manifest")

Package archives produced by pm archive are only needed if you need to like email the package to someone; if you're just planning to publish it into a package repository it's not necessary (and is slower, since it has to make an extra copy of all the files)

@tmandry
Copy link
Member

tmandry commented Jul 28, 2022

r? @tmandry

@rust-highfive rust-highfive assigned tmandry and unassigned ehuss Jul 28, 2022
@ehuss
Copy link
Contributor

ehuss commented Jul 28, 2022

Please also add a link in https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/SUMMARY.md (otherwise this page won't show up anywhere).

Copy link
Member

@tmandry tmandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks quite good.

src/doc/rustc/src/platform-support/fuchsia.md Show resolved Hide resolved
src/doc/rustc/src/platform-support/fuchsia.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/fuchsia.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/fuchsia.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/fuchsia.md Show resolved Hide resolved
src/doc/rustc/src/platform-support/fuchsia.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/fuchsia.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/fuchsia.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/fuchsia.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/fuchsia.md Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

@djkoloski djkoloski force-pushed the add_fuchsia_target_documentation branch from 9466388 to e65351f Compare July 28, 2022 19:57
@tmandry
Copy link
Member

tmandry commented Jul 28, 2022

@bors delegate+

r=tmandry with typo fixed

@bors
Copy link
Contributor

bors commented Jul 28, 2022

✌️ @djkoloski can now approve this pull request

@djkoloski djkoloski force-pushed the add_fuchsia_target_documentation branch from e65351f to 0fcb86b Compare July 28, 2022 20:37
@djkoloski
Copy link
Contributor Author

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 29, 2022

📌 Commit 0fcb86b has been approved by djkoloski

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2022
@tmandry
Copy link
Member

tmandry commented Jul 29, 2022

@bors r=tmandry

@bors
Copy link
Contributor

bors commented Jul 29, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jul 29, 2022

📌 Commit 0fcb86b has been approved by tmandry

It is now in the queue for this repository.

@tmandry tmandry mentioned this pull request Jul 29, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#99227 (Fix thumbv4t-none-eabi frame pointer setting)
 - rust-lang#99518 (Let-else: break out scopes when a let-else pattern fails to match)
 - rust-lang#99671 (Suggest dereferencing index when trying to use a reference of usize as index)
 - rust-lang#99831 (Add Fuchsia platform support documentation)
 - rust-lang#99881 (fix ICE when computing codegen_fn_attrs on closure with non-fn parent)
 - rust-lang#99888 (Streamline lint checking)
 - rust-lang#99891 (Adjust an expr span to account for macros)
 - rust-lang#99904 (Cleanup html whitespace)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 59320d5 into rust-lang:master Jul 30, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 30, 2022
@workingjubilee workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants