rustdoc: use <details> tag for the source code sidebar #98773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the extremely poor accessibility of the old system, making it possible to navigate the sidebar by keyboard, and also implicitly gives the sidebar items the correct ARIA roles.
rustbot
added
the
T-rustdoc
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/source-sidebar-details
branch
from
b0939ca
to
1f621fb
Compare
|
@GuillaumeGomez In response to #98772 (comment) I see it now. Here's a version with some more spacing added inside the source view sidebar:
|
|
Can you just add a test for the |
|
@GuillaumeGomez Sure, test case added. |
GuillaumeGomez
approved these changes
Jul 3, 2022
|
Thanks! @bors r+ rollup |
|
📌 Commit e710ac1 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 3, 2022
…details, r=GuillaumeGomez rustdoc: use <details> tag for the source code sidebar This fixes the extremely poor accessibility of the old system, making it possible to navigate the sidebar by keyboard, and also implicitly gives the sidebar items the correct ARIA roles. Split out separately from rust-lang#98772
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jul 3, 2022
…details, r=GuillaumeGomez rustdoc: use <details> tag for the source code sidebar This fixes the extremely poor accessibility of the old system, making it possible to navigate the sidebar by keyboard, and also implicitly gives the sidebar items the correct ARIA roles. Split out separately from rust-lang#98772
This was referenced Jul 3, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 3, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#94831 (Link to stabilization section in std-dev-guide for library tracking issue template) - rust-lang#98764 (add Miri to the nightly docs) - rust-lang#98773 (rustdoc: use <details> tag for the source code sidebar) - rust-lang#98799 (Fix bug in `rustdoc -Whelp`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the extremely poor accessibility of the old system, making it possible to navigate the sidebar by keyboard, and also implicitly gives the sidebar items the correct ARIA roles.
Split out separately from #98772