Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Miri to the nightly docs #98764

Merged
merged 3 commits into from
Jul 4, 2022
Merged

add Miri to the nightly docs #98764

merged 3 commits into from
Jul 4, 2022

Conversation

b-ncMN
Copy link
Contributor

@b-ncMN b-ncMN commented Jul 1, 2022

This is a follow-up to #97773 and to #98714

It adds miri to the doc.rust-lang.org/nightly/nightly-rustc](https://doc.rust-lang.org/nightly/nightly-rustc/

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2022
@jyn514 jyn514 changed the title Miri rustdoc add Miri to the nightly docs Jul 1, 2022
@jyn514 jyn514 assigned jyn514 and unassigned Mark-Simulacrum Jul 1, 2022
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-miri Area: The miri tool labels Jul 1, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 1, 2022

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Jul 1, 2022

📌 Commit c5381b4 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2022
@RalfJung RalfJung mentioned this pull request Jul 1, 2022
Closed
RalfJung added a commit to RalfJung/rust that referenced this pull request Jul 3, 2022
@RalfJung
Rollup merge of rust-lang#98764 - InfRandomness:miri-rustdoc, r=jyn514
8974fa3 
add Miri to the nightly docs

This is a follow-up to rust-lang#97773 and to rust-lang#98714

It adds miri to the doc.rust-lang.org/nightly/nightly-rustc](https://doc.rust-lang.org/nightly/nightly-rustc/
@RalfJung RalfJung mentioned this pull request Jul 3, 2022
Closed
@RalfJung
Copy link
Member

RalfJung commented Jul 3, 2022

Failed in rollup: #98853 (comment)
@bors r-

I have no idea why this is happening... but I think it must be this PR

[TIMING] test::Miri { stage: 2, host: x86_64-unknown-linux-gnu } -- 92.984
Build completed successfully in 0:24:13
{"miri":"test-pass","reference":"test-pass","rust-by-example":"test-pass","rustbook":"test-fail","embedded-book":"test-pass","rls":"test-pass","book":"test-pass","nomicon":"test-pass","cargo-miri":"test-fail","edition-guide":"test-pass"}Building rustbuild
    Finished dev [unoptimized] target(s) in 0.07s
Verifying status of book...
Verifying status of nomicon...
Verifying status of reference...
Verifying status of rust-by-example...
Verifying status of edition-guide...
Verifying status of rls...
Verifying status of miri...
Verifying status of embedded-book...
fatal: could not create work tree dir 'rust-toolstate': Read-only file system
thread 'main' panicked at 'git clone unsuccessful (status: Ok(ExitStatus(unix_wait_status(32768))))', toolstate.rs:322:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 0:00:00

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2022
@b-ncMN
Copy link
Contributor Author

b-ncMN commented Jul 3, 2022

I don't see how this PR could cause this 🤔

@b-ncMN
Copy link
Contributor Author

b-ncMN commented Jul 3, 2022

Rebased to upstream/master

@RalfJung
Copy link
Member

RalfJung commented Jul 3, 2022

Hm yeah it also happened in #98859. Might be an infra problem?
@bors r=jyn514

@bors
Copy link
Contributor

bors commented Jul 3, 2022

📌 Commit ed92d88 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2022
@b-ncMN
Copy link
Contributor Author

b-ncMN commented Jul 3, 2022

I would love to try and run src/ci/scripts/run-build-from-ci.sh but that script does not want to run because it's not in a CI environment
this is very annoying.

@b-ncMN
Copy link
Contributor Author

b-ncMN commented Jul 3, 2022

Hm yeah it also happened in #98859. Might be an infra problem? @bors r=jyn514

Might be a good idea to retry tomorrow ?

@RalfJung RalfJung mentioned this pull request Jul 3, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 3, 2022
@bors
Auto merge of rust-lang#98864 - RalfJung:rollup-ptzklyc, r=RalfJung
2557603 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#94831 (Link to stabilization section in std-dev-guide for library tracking issue template)
 - rust-lang#98764 (add Miri to the nightly docs)
 - rust-lang#98773 (rustdoc: use <details> tag for the source code sidebar)
 - rust-lang#98799 (Fix bug in `rustdoc -Whelp`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b0d831a into rust-lang:master Jul 4, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 4, 2022
@b-ncMN b-ncMN deleted the miri-rustdoc branch July 4, 2022 06:39
@RalfJung RalfJung mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-miri Area: The miri tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
7 participants
@b-ncMN @rust-highfive @jyn514 @bors @RalfJung @Mark-Simulacrum @rustbot