Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve println! documentation #97131

Merged
merged 1 commit into from
May 19, 2022
Merged

Improve println! documentation #97131

merged 1 commit into from
May 19, 2022

Conversation

gimbling-away
Copy link
Contributor

No description provided.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 18, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 18, 2022

📌 Commit a47edcf has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2022
@JohnTitor
Copy link
Member

Oh well, we were reviewing at the same time!?

JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 18, 2022
@JohnTitor
Rollup merge of rust-lang#97131 - gimbles:patch-2, r=Dylan-DPC
4fb2f33 
Improve println! documentation
@JohnTitor JohnTitor mentioned this pull request May 18, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request May 18, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2022
@bors
Auto merge of rust-lang#97159 - JohnTitor:rollup-ibl51vw, r=JohnTitor
e6327bc 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96866 (Switch CI bucket uploads to intelligent tiering)
 - rust-lang#97062 (Couple of refactorings to cg_ssa::base::codegen_crate)
 - rust-lang#97127 (Revert "Auto merge of rust-lang#96441 - ChrisDenton:sync-pipes, r=m-ou-se")
 - rust-lang#97131 (Improve println! documentation)
 - rust-lang#97139 (Move some settings DOM generation out of JS)
 - rust-lang#97152 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b7d72ad into rust-lang:master May 19, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 19, 2022
@gimbling-away gimbling-away deleted the patch-2 branch May 19, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@jyn514 jyn514 jyn514 approved these changes

Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
8 participants
@gimbling-away @rust-highfive @Dylan-DPC @bors @JohnTitor @jyn514 @joshtriplett @rustbot