Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Auto merge of #96441 - ChrisDenton:sync-pipes, r=m-ou-se" #97127

Merged
merged 1 commit into from
May 19, 2022
Merged

Revert "Auto merge of #96441 - ChrisDenton:sync-pipes, r=m-ou-se" #97127

merged 1 commit into from
May 19, 2022

Conversation

Mark-Simulacrum
Copy link
Member

This reverts commit ddb7fbe.

Partially addresses #97124, but not marking as fixed as we're still pending on a beta backport (for 1.62, which is happening in #97088).

r? @m-ou-se @ChrisDenton

@Mark-Simulacrum
Revert "Auto merge of rust-lang#96441 - ChrisDenton:sync-pipes, r=m-o…
6259670 
…u-se"

This reverts commit ddb7fbe, reversing
changes made to baaa3b6.
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 17, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2022
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 17, 2022
Closed
@m-ou-se
Copy link
Member

m-ou-se commented May 18, 2022

@bors r+

:(

Posted a comment here: tokio-rs/tokio#4670 (comment)

@bors
Copy link
Contributor

bors commented May 18, 2022

📌 Commit 6259670 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 18, 2022
@JohnTitor
Rollup merge of rust-lang#97127 - Mark-Simulacrum:revert-96441, r=m-o…
beaa27b 
…u-se

Revert "Auto merge of rust-lang#96441 - ChrisDenton:sync-pipes, r=m-ou-se"

This reverts commit ddb7fbe.

Partially addresses rust-lang#97124, but not marking as fixed as we're still pending on a beta backport (for 1.62, which is happening in rust-lang#97088).

r? `@m-ou-se` `@ChrisDenton`
@JohnTitor JohnTitor mentioned this pull request May 18, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request May 18, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2022
@bors
Auto merge of rust-lang#97159 - JohnTitor:rollup-ibl51vw, r=JohnTitor
e6327bc 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96866 (Switch CI bucket uploads to intelligent tiering)
 - rust-lang#97062 (Couple of refactorings to cg_ssa::base::codegen_crate)
 - rust-lang#97127 (Revert "Auto merge of rust-lang#96441 - ChrisDenton:sync-pipes, r=m-ou-se")
 - rust-lang#97131 (Improve println! documentation)
 - rust-lang#97139 (Move some settings DOM generation out of JS)
 - rust-lang#97152 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8aba26d into rust-lang:master May 19, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @rust-highfive @m-ou-se @bors @rustbot