Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta][1.57] Disable outline atomics for aarch64-unknown-linux-musl #91220

Closed
wants to merge 1 commit into from

Conversation

hkratz
Copy link
Contributor

@hkratz hkratz commented Nov 25, 2021

This is a functionally equivalent, minimally invasive backport of #90044, which fixes the problem that compiling any binary with the target aarch64-unknown-linux-musl fails unless lld is used for linking (#89626).

I have tested this backport by building aarch64-unknown-linux-gnu, installing the std libraries for the -musl and -gnu variants in rustc-beta-aarch64-unknown-linux-gnu/rustc/lib/rustlib and running helloworld successfully for both targets on arm64 hardware.

cc @workingjubilee @pnkfelix

This is a functionally equivalent, minimally invasive backport of rust-lang#90044.

backport-of: nothing
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2021
@hkratz hkratz changed the title [beta] Disable outline atomics to aarch64-unknown-linux-musl [beta][1.57] Disable outline atomics to aarch64-unknown-linux-musl Nov 25, 2021
@hkratz hkratz changed the title [beta][1.57] Disable outline atomics to aarch64-unknown-linux-musl [beta][1.57] Disable outline atomics for aarch64-unknown-linux-musl Nov 29, 2021
@Mark-Simulacrum
Copy link
Member

bundled into #91361, closing.

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2021
…imulacrum

[stable] 1.57.0 artifacts

This is the standard beta->stable promotion, and includes a last-minute backports of:

* rust-lang#90044 via inclusion of rust-lang#91220.
*  [beta] Don't treat unnormalized function arguments as well-formed rust-lang#91242

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants