Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Don't treat unnormalized function arguments as well-formed #91242

Closed
wants to merge 58 commits into from

Conversation

jackh726
Copy link
Member

Partial revert of #88312

r? @pnkfelix
cc @nikomatsakis

pietroalbini and others added 30 commits October 18, 2021 09:57
Rust 1.57.0 beta release

This PR bumps 1.57.0 to the beta channel.

r? `@ghost`
cc `@rust-lang/release`
…ans, r=estebank"

This reverts commit 36a1076, reversing
changes made to e1e9319.
This can append if within the same module a `#[macro_export] macro_rules!`
is declared but also a reexport of itself producing two export of the same
macro in the same module. In that case we only want to document it once.
Includes rust-lang/cargo#9979: Fix fetching git repos after a force push.
…ulacrum

[beta] backports

*  Don't emit a warning for empty rmeta files. rust-lang#90072
*  Erase late-bound regions before computing vtable debuginfo name. rust-lang#90050
*  Fix wrong niche calculation when 2+ niches are placed at the start rust-lang#90040
*  Revert rust-lang#86011 to fix an incorrect bound check rust-lang#90025
*  Fix macro_rules! duplication when reexported in the same module rust-lang#89867
* Bump cargo to include rust-lang/cargo#9979 - Fix fetching git repos after a force push.

r? `@Mark-Simulacrum`
[beta] Fix CVE-2021-42574

This PR implements new lints to mitigate the impact of [CVE-2021-42574], caused by the presence of bidirectional-override Unicode codepoints in the compiled source code. [See the advisory][advisory] for more information about the vulnerability.

The changes in this PR will be released in tomorrow's beta release.

[CVE-2021-42574]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-42574
[advisory]: https://blog.rust-lang.org/2021/11/01/cve-2021-42574.html
…lip1995

Move if_then_panic to pedantic and rename to manual_assert
[beta] Backport: Move if_then_panic to pedantic and rename to manual_assert

Backport of rust-lang#7810

cc `@camsteffen`

r? `@ghost`

changelog: none (same release)
As discussed in rust-lang#88576, raw handle values in Windows can be null, such
as in `windows_subsystem` mode, or when consoles are detached from a
process. So, don't use `NonNull` to hold them, don't assert that they're
not null, and remove `OwnedHandle`'s `repr(transparent)`. Introduce a
new `HandleOrNull` type, similar to `HandleOrInvalid`, to cover the FFI
use case.

(cherry picked from commit 3b97481)
(cherry picked from commit e102c2a)
This lint is not yet ready for stable use, primarily due to false positives in edge
cases; we want to test it out more before stabilizing.

(cherry picked from commit 185fa56)
In rust-lang#89522 we learned that `clone3` is interacting poorly with Gentoo's
`sandbox` tool. We only need that for the unstable pidfd extensions, so
otherwise avoid that and use a normal `fork`.

(cherry picked from commit 85b55ce)
bors and others added 3 commits November 19, 2021 09:02
[beta] backports

-  Fix assertion failures in OwnedHandle with windows_subsystem. rust-lang#88798
-  Ensure that pushing empty path works as before on verbatim paths rust-lang#89665
-  Feature gate + make must_not_suspend allow-by-default rust-lang#89826
-  Only use clone3 when needed for pidfd rust-lang#89930
-  Fix documentation header sizes rust-lang#90186
-  Fixes incorrect handling of ADT's drop requirements rust-lang#90218
-  Fix ICE when forgetting to Box a parameter to a Self::func call rust-lang#90221
-  Prevent duplicate caller bounds candidates by exposing default substs in Unevaluated rust-lang#90266
-  Update odht crate to 0.3.1 (big-endian bugfix) rust-lang#90403
-  rustdoc: Go back to loading all external crates unconditionally rust-lang#90489
-  Split doc_cfg and doc_auto_cfg features rust-lang#90502
-  Apply adjustments for field expression even if inaccessible rust-lang#90508
-  Warn for variables that are no longer captured rust-lang#90597
-  Properly register text_direction_codepoint_in_comment lint. rust-lang#90626
-  CI: Use ubuntu image to download openssl, curl sources, cacert.pem for x86 dist builds rust-lang#90457
-  Android is not GNU rust-lang#90834
-  Update llvm submodule rust-lang#90954

Additionally, this bumps the stage 0 compiler from beta to stable 1.56.1.

r? `@Mark-Simulacrum`
…lacrum

[beta] Backport Clippy lint renaming / regrouping

This backports PR rust-lang/rust-clippy#7810 to beta, where a lint added in the 1.57 (current beta) release cycle was renamed shortly after the beta cutoff. We want to backport this, so we don't have unnecessary `lint_store.registered_renamed` calls in the Clippy codebase forever.

(The formatting changes were necessary to pass this backport in the Clippy CI, removing it in a subtree sync would be a bit painful...)

cc `@camsteffen`
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2021
@jackh726 jackh726 changed the title Don't treat unnormalized function arguments as well-formed [beta] Don't treat unnormalized function arguments as well-formed Nov 26, 2021
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 29, 2021

📌 Commit da0dc91 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2021
@jackh726
Copy link
Member Author

@bors p=1 timing-sensitive

@bors
Copy link
Contributor

bors commented Nov 29, 2021

☔ The latest upstream changes (presumably #91269) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 29, 2021
@Mark-Simulacrum
Copy link
Member

included in stable promotion, closing this PR.

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2021
…imulacrum

[stable] 1.57.0 artifacts

This is the standard beta->stable promotion, and includes a last-minute backports of:

* rust-lang#90044 via inclusion of rust-lang#91220.
*  [beta] Don't treat unnormalized function arguments as well-formed rust-lang#91242

r? `@Mark-Simulacrum`
@jackh726 jackh726 deleted the issue-91068-beta branch March 12, 2022 18:10
@jackh726 jackh726 restored the issue-91068-beta branch March 12, 2022 18:30
@jackh726 jackh726 deleted the issue-91068-beta branch March 12, 2022 18:40
@jackh726 jackh726 restored the issue-91068-beta branch March 12, 2022 18:42
@jackh726 jackh726 deleted the issue-91068-beta branch March 12, 2022 18:45
@jackh726 jackh726 restored the issue-91068-beta branch March 12, 2022 18:48
@jackh726 jackh726 deleted the issue-91068-beta branch March 12, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.