Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test in std::process on android #91151

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Fix test in std::process on android #91151

merged 1 commit into from
Nov 25, 2021

Conversation

name1e5s
Copy link
Contributor

closes #10380

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@name1e5s name1e5s force-pushed the chore/process_test branch 2 times, most recently from 7a0fcf6 to 5513eb1 Compare November 23, 2021 05:47
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se
Copy link
Member

m-ou-se commented Nov 23, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Nov 23, 2021

📌 Commit 08a500f has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2021
@m-ou-se m-ou-se added the O-android Operating system: Android label Nov 23, 2021
@m-ou-se m-ou-se assigned m-ou-se and unassigned joshtriplett Nov 23, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 23, 2021
@matthiaskrgr
Rollup merge of rust-lang#91151 - name1e5s:chore/process_test, r=m-ou-se
5c8ed8f 
Fix test in std::process on android

closes rust-lang#10380
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 23, 2021
Closed
@bors
Copy link
Contributor

bors commented Nov 24, 2021

⌛ Testing commit 08a500f with merge b87117784a27dbcec7348b7a7d40e4a6ea175a41...

@bors
Copy link
Contributor

bors commented Nov 24, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2021
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
......... (50/53)
...        (53/53)


/checkout/src/test/rustdoc-gui/toggle-click-deadspace.goml toggle-click-deadspace... FAILED
[ERROR] (line 8) Error: Evaluation failed: assert didn't fail: for command `assert-attribute-false: (".impl-items .rustdoc-toggle", {"open": ""})`



command did not execute successfully: "/node-v14.4.0-linux-x64/bin/node" "/checkout/src/tools/rustdoc-gui/tester.js" "--jobs" "16" "--doc-folder" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc" "--tests-folder" "/checkout/src/test/rustdoc-gui"


Build completed unsuccessfully in 0:00:19

@m-ou-se
Copy link
Member

m-ou-se commented Nov 24, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 24, 2021
@GuillaumeGomez
Rollup merge of rust-lang#91151 - name1e5s:chore/process_test, r=m-ou-se
9e73b07 
Fix test in std::process on android

closes rust-lang#10380
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 24, 2021
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 24, 2021
@GuillaumeGomez
Rollup merge of rust-lang#91151 - name1e5s:chore/process_test, r=m-ou-se
e5aeec4 
Fix test in std::process on android

closes rust-lang#10380
This was referenced Nov 24, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2021
@bors
Auto merge of rust-lang#91203 - GuillaumeGomez:rollup-kwtqvb1, r=Guil…
d2c24aa 
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#89542 (Partially stabilize `duration_consts_2`)
 - rust-lang#90044 (Restrict aarch64 outline atomics to glibc for now.)
 - rust-lang#90420 (Create rustdoc_internals feature gate)
 - rust-lang#91075 (Reduce prominence of item-infos)
 - rust-lang#91151 (Fix test in std::process on android)
 - rust-lang#91179 (Fix more <a> color)
 - rust-lang#91199 (rustdoc: Add test for mixing doc comments and attrs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a81f361 into rust-lang:master Nov 25, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
O-android Operating system: Android S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

fix to pass 7 tests in run::test and test/run-pass/rtio-processes.rs on android
7 participants
@name1e5s @rust-highfive @rust-log-analyzer @m-ou-se @bors @joshtriplett @rustbot