Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to pass 7 tests in run::test and test/run-pass/rtio-processes.rs on android #10380

Closed
yichoi opened this issue Nov 9, 2013 · 7 comments · Fixed by #91151
Closed

fix to pass 7 tests in run::test and test/run-pass/rtio-processes.rs on android #10380

yichoi opened this issue Nov 9, 2013 · 7 comments · Fixed by #91151
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. O-android Operating system: Android

Comments

@yichoi
Copy link
Contributor

yichoi commented Nov 9, 2013

To enable test on android bot #9120

run::tests::test_finish_once
run::tests::test_finish_twice
run::tests::test_finish_with_output_once
run::tests::test_finish_with_output_twice
run::tests::test_process_output_error
run::tests::test_process_output_output
run::tests::test_process_status

and

test/run-pass/rtio-processes.rs

It looks to me RtioProcess does not work properly on android.

@yichoi
Copy link
Contributor Author

yichoi commented Nov 10, 2013

logs are

task 'tests::test_finish_once' failed at 'assertion failed: `(left == right) && (right == left)` (left: `1081820432`, right: `1`)', run.rs:475
FAILED
test tests::test_finish_twice ... task 'tests::test_finish_twice' failed at 'assertion failed: `(left == right) && (right == left)` (left: `1081820432`, right: `1`)', run.rs:490
FAILED
test tests::test_finish_with_output_once ... task 'tests::test_finish_with_output_once' failed at 'assertion failed: `(left == right) && (right == left)` (left: `1081820432`, right: `0`)', run.rs:520
FAILED
test tests::test_finish_with_output_twice ... task 'tests::test_finish_with_output_twice' failed at 'assertion failed: `(left == right) && (right == left)` (left: `1081820432`, right: `0`)', run.rs:566
FAILED
test tests::test_inherit_env ... ok
test tests::test_keep_current_working_dir ... ok
test tests::test_pipes ... ignored
test tests::test_process_output_error ... task 'tests::test_process_output_error' failed at 'assertion failed: `(left == right) && (right == left)` (left: `1081820432`, right: `255`)', run.rs:408
FAILED
test tests::test_process_output_output ... task 'tests::test_process_output_output' failed at 'assertion failed: `(left == right) && (right == left)` (left: `1081820432`, right: `0`)', run.rs:382
FAILED
test tests::test_process_status ... task 'tests::test_process_status' failed at 'assertion failed: `(left == right) && (right == left)` (left: `1081820432`, right: `1`)', run.rs:355
FAILED

failures:
    tests::test_finish_once
    tests::test_finish_twice
    tests::test_finish_with_output_once
    tests::test_finish_with_output_twice
    tests::test_process_output_error
    tests::test_process_output_output
    tests::test_process_status

@alexcrichton
Copy link
Member

Hm this may be an FFI issue with libuv. I realized during my uv rewrite that libuv is giving us an int64_t exit status and we think it's a c_int.

Once #10321 lands this may be fixed.

@pnkfelix
Copy link
Member

Hmm, this issue number has propagated to several more tests that are cfg-disabled on android. (Some of which are now failing when I mixed in a Boehm/BDW conservative GC into the runtime, in particular io::process::tests::stdin_works::native.)

@pnkfelix
Copy link
Member

Also, #10321 has landed, so it would be good to determine if these tests now work on Android.

@huonw
Copy link
Member

huonw commented Nov 21, 2014

Triage: I have no idea how to test this, but a lot has changed in a year (especially the removal of green & libuv), so these may be magically fixed; if someone can check.

@steveklabnik
Copy link
Member

Triage: rtio is gone, but all these tests in std::process are still ignored for android.

@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 19, 2017
@euclio
Copy link
Contributor

euclio commented Aug 25, 2017

I tried to run these tests with ./src/ci/docker/run.sh arm-android but they all failed with No such file or directory, which seems suspect (at least for the tests that invoke mkdir, true, echo, etc.). Is there a better way to test? I have an android device available.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 23, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 24, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 24, 2021
@bors bors closed this as completed in a81f361 Nov 25, 2021
Jarcho pushed a commit to Jarcho/rust that referenced this issue Feb 26, 2023
…ansion, r=xFrednet

Ignore lifetimes from differing contexts in `needless_lifetimes`

Fixes rust-lang#10379

changelog: [`needless_lifetimes`]: Don't lint signatures in macros if the lifetime is a metavariable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. O-android Operating system: Android
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants