Add more text and examples to carrying_{add|mul}
#90556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
scottmcm
commented
Nov 4, 2021
| #[doc = concat!($AdaptiveTestPrefix, "assert_eq!(", | ||
| stringify!($SelfT), "::MAX.carrying_mul(", stringify!($SelfT), "::MAX, ", stringify!($SelfT), "::MAX), ", | ||
| "(0, ", stringify!($SelfT), "::MAX));" | ||
| )] |
There was a problem hiding this comment.
$AdaptiveTestPrefix is a bit of a hack because this currently doesn't pass on signed types. It's unclear to me whether it should -- there's open questions about this method on signed types in things like #90493 -- so for now it's just skipped and hidden.
|
r? @scottmcm |
|
Er, oops. I assigned this to you because you posted what looked like a review comment, and I didn't catch that you were also the PR author. :) |
|
This looks reasonable to me. The issue with the signed methods definitely needs resolving before we consider stabilizing |
|
@bors r+ |
|
📌 Commit dc2c260 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2021
…riplett
Add more text and examples to `carrying_{add|mul}`
`feature(bigint_helper_methods)` tracking issue rust-lang#85532
cc `@clarfonthey`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2021
…riplett
Add more text and examples to `carrying_{add|mul}`
`feature(bigint_helper_methods)` tracking issue rust-lang#85532
cc ``@clarfonthey``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2021
…riplett
Add more text and examples to `carrying_{add|mul}`
`feature(bigint_helper_methods)` tracking issue rust-lang#85532
cc ```@clarfonthey```
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2021
…riplett
Add more text and examples to `carrying_{add|mul}`
`feature(bigint_helper_methods)` tracking issue rust-lang#85532
cc ````@clarfonthey````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#90507 (Suggest `extern crate alloc` when using undeclared module `alloc`) - rust-lang#90530 (Simplify js tester a bit) - rust-lang#90533 (Add note about x86 instruction prefixes in asm! to unstable book) - rust-lang#90537 (Update aarch64 `target_feature` list for LLVM 12.) - rust-lang#90544 (Demote metadata load warning to "info".) - rust-lang#90554 (Clean up some `-Z unstable-options` in tests.) - rust-lang#90556 (Add more text and examples to `carrying_{add|mul}`) - rust-lang#90563 (rustbot allow labels) - rust-lang#90571 (Fix missing bottom border for headings in sidebar) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature(bigint_helper_methods)tracking issue #85532cc @clarfonthey