Simplify js tester a bit #90530
Merged
Simplify js tester a bit #90530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
notriddle
reviewed
Nov 3, 2021
src/tools/rustdoc-js/tester.js
Outdated
| || args[i] === "--test-folder" | ||
| || args[i] === "--test-file" | ||
| || args[i] === "--crate-name") { | ||
| if (correspondances[args[i]] !== undefined) { |
There was a problem hiding this comment.
Suggested change
| if (correspondances[args[i]] !== undefined) { | |
| if (Object.hasOwn(correspondances, args[i])) { |
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn
There was a problem hiding this comment.
Also, a nit: "correspondances" should be spelled "correspondences". While you're at it, do you want to fix the spelling?
camelid
added
the
C-cleanup
GuillaumeGomez
force-pushed
the
simplify-js-tester
branch
from
9130907
to
f30ac52
Compare
|
Updated. TIL thanks to both of you. :) |
This comment has been minimized.
This comment has been minimized.
|
@notriddle I didn't check the requirements but they're quite high in fact! I'll revert to |
GuillaumeGomez
force-pushed
the
simplify-js-tester
branch
from
f30ac52
to
f983e71
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
simplify-js-tester
branch
from
f983e71
to
3f496b5
Compare
|
So apparently, |
notriddle
approved these changes
Nov 3, 2021
|
@bors: r=notriddle rollup |
|
📌 Commit 3f496b5 has been approved by |
bors
added
the
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2021
…r=notriddle Simplify js tester a bit r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2021
…r=notriddle Simplify js tester a bit r? ``@notriddle``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2021
…r=notriddle Simplify js tester a bit r? ```@notriddle```
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2021
…r=notriddle Simplify js tester a bit r? ````@notriddle````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#90507 (Suggest `extern crate alloc` when using undeclared module `alloc`) - rust-lang#90530 (Simplify js tester a bit) - rust-lang#90533 (Add note about x86 instruction prefixes in asm! to unstable book) - rust-lang#90537 (Update aarch64 `target_feature` list for LLVM 12.) - rust-lang#90544 (Demote metadata load warning to "info".) - rust-lang#90554 (Clean up some `-Z unstable-options` in tests.) - rust-lang#90556 (Add more text and examples to `carrying_{add|mul}`) - rust-lang#90563 (rustbot allow labels) - rust-lang#90571 (Fix missing bottom border for headings in sidebar) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @notriddle