Rollup of 15 pull requests #90159
Closed
Rollup of 15 pull requests #90159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As you can see in src/test/ui/traits/self-without-lifetime-constraint.stderr you can get very confusing type names if you don't have this. Fixes rust-lang#87763
It's a visitor property rather than something that needs to be determined at runtime
The const qualification was so far performed before the promotion and the implementation assumed that it will never encounter a promoted. With `const_precise_live_drops` feature, checking for live drops is delayed until after drop elaboration, which in turn runs after promotion. so the assumption is no longer true. When evaluating `NeedsNonConstDrop` it is now possible to encounter promoteds. Use type base qualification for the promoted. It is a sound approximation in general, and in the specific case of promoteds and `NeedsNonConstDrop` it is precise.
Now explicitly says negative value.
rustbot doesn't allow unauthenticated users to set `I-nominated`; apply the same permissions to the new `I-*nominated` labels.
Previously, it wasn't clear whether "This could include" was referring to logic errors, or undefined behaviour. Tweak wording to clarify this sentence does not relate to UB.
…rk-Simulacrum Clarify undefined behaviour in binary heap, btree and hashset docs Previously, it wasn't clear whether "This could include" was referring to logic errors, or undefined behaviour. Tweak wording to clarify this sentence does not relate to UB.
Stabilize feature `saturating_div` for rust 1.58.0 The tracking issue is rust-lang#89381 This seems like a reasonable simple change(?). The feature `saturating_div` was added as part of the ongoing effort to implement a `Saturating` integer type (see rust-lang#87921). The implementation has been discussed [here](rust-lang#87921 (comment)) and [here](rust-lang#87921 (comment)). It extends the list of saturating operations on integer types (like `saturating_add`, `saturating_sub`, `saturating_mul`, ...) by the function `fn saturating_div(self, rhs: Self) -> Self`. The stabilization of the feature `saturating_int_impl` (for the `Saturating` type) needs to have this stabilized first. Closes rust-lang#89381
…bank Give better error for `macro_rules name` follow up to rust-lang#89221 r? `@estebank` `@rustbot` modify labels: +A-diagnostics +A-parser
…fetimes-in-region-errors, r=jackh726 nice_region_error: Include lifetime placeholders in error output As you can see in src/test/ui/traits/self-without-lifetime-constraint.stderr you can get very confusing type names if you don't have this. Fixes rust-lang#87763
Ensure that pushing empty path works as before on verbatim paths Fixes: rust-lang#89658 Signed-off-by: Sean Young <[email protected]>
…vidtwco Don't mark for loop iter expression as desugared We typically don't mark spans of lowered things as desugared. This helps Clippy rightly discern when code is (not) from expansion. This was discovered by `@flip1995` at rust-lang/rust-clippy#7789 (comment).
Update E0637 description to mention `&` w/o an explicit lifetime name Deal with rust-lang#89824 (comment). Another solution would be splitting the error code into two as (I think) it's a bit unclear to users why they have the same error code.
Change `Duration::[try_]from_secs_{f32, f64}` underflow error
The error message now says that it was a negative value.
Fixes rust-lang#89913.
rustc_ast: Turn `MutVisitor::token_visiting_enabled` into a constant It's a visitor property rather than something that needs to be determined at runtime
…=spastorino Reject closures in patterns Fixes rust-lang#90013.
…i-obk Fix const qualification when executed after promotion The const qualification was so far performed before the promotion and the implementation assumed that it will never encounter a promoted. With `const_precise_live_drops` feature, checking for live drops is delayed until after drop elaboration, which in turn runs after promotion. so the assumption is no longer true. When evaluating `NeedsNonConstDrop` it is now possible to encounter promoteds. Use type base qualification for the promoted. It is a sound approximation in general, and in the specific case of promoteds and `NeedsNonConstDrop` it is precise. Fixes rust-lang#89938.
…crum Add a regression test for issue-83479 Add a regression test for rust-lang#83479 (comment), but not close the issue, see rust-lang#83479 (comment).
Add some tests for const_generics_defaults I think this covers some of the stuff required for stabilisation report, some of these tests are probably covering stuff we already have but it can't hurt to have more :) r? ```@lcnr```
Add test for issue rust-lang#78561 Adds test for and closes rust-lang#78561 which previously crashed compiler.
…=Mark-Simulacrum triagebot: Treat `I-*nominated` like `I-nominated` rustbot doesn't allow unauthenticated users to set `I-nominated`; apply the same permissions to the new `I-*nominated` labels.
|
@bors r+ p=15 rollup=never |
|
📌 Commit 1fbce5c has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 1fbce5c with merge 300296496b5eb96a6cf2e7ee879bdf5d527140ce... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Vic23M
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
saturating_divfor rust 1.58.0 #88624 (Stabilize featuresaturating_divfor rust 1.58.0)macro_rules name#89257 (Give better error formacro_rules name)&w/o an explicit lifetime name #89922 (Update E0637 description to mention&w/o an explicit lifetime name)Duration::[try_]from_secs_{f32, f64}underflow error #89944 (ChangeDuration::[try_]from_secs_{f32, f64}underflow error)MutVisitor::token_visiting_enabledinto a constant #89991 (rustc_ast: TurnMutVisitor::token_visiting_enabledinto a constant)region is not an ReVar: ReEarlyBound(0, 'a)with type_alias_impl_trait and particular type parameter bounds #78561)I-*nominatedlikeI-nominated#90129 (triagebot: TreatI-*nominatedlikeI-nominated)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup