Give better error for macro_rules! name!
#89221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
rustbot
added
A-diagnostics
estebank
approved these changes
Sep 24, 2021
| if self.eat(&token::Not) { | ||
| // Handle macro_rules! foo! | ||
| let span = self.prev_token.span; | ||
| self.struct_span_err(self.prev_token.span, "macro names arn't followed by a `!`") |
There was a problem hiding this comment.
Suggested change
| self.struct_span_err(self.prev_token.span, "macro names arn't followed by a `!`") | |
| self.struct_span_err(span, "macro names aren't followed by a `!`") |
| self.struct_span_err(self.prev_token.span, "macro names arn't followed by a `!`") | ||
| .span_suggestion_verbose( | ||
| span, | ||
| "try removing this `!`", |
There was a problem hiding this comment.
Suggested change
| "try removing this `!`", | |
| "removing the `!`", |
| // Handle macro_rules! foo! | ||
| let span = self.prev_token.span; | ||
| self.struct_span_err(self.prev_token.span, "macro names arn't followed by a `!`") | ||
| .span_suggestion_verbose( |
There was a problem hiding this comment.
I think this one is ok to be inline: we're asking them to remove the whole thing in that is underlined, it should be fine.
Suggested change
| .span_suggestion_verbose( | |
| .span_suggestion( |
aDotInTheVoid
force-pushed
the
macro-error-1
branch
from
ef59487
to
f4a64eb
Compare
aDotInTheVoid
force-pushed
the
macro-error-1
branch
from
f4a64eb
to
ed3b751
Compare
|
@bors r+ rollup |
|
📌 Commit ed3b751 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 24, 2021
…bank Give better error for `macro_rules! name!` r? `@estebank` `@rustbot` modify labels: +A-diagnostics +A-parser
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2021
…ingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#88893 (Add 1.56.0 release notes) - rust-lang#89001 (Be explicit about using Binder::dummy) - rust-lang#89072 (Avoid a couple of Symbol::as_str calls in cg_llvm ) - rust-lang#89104 (Simplify scoped_thread) - rust-lang#89208 ([rfc 2229] Drop fully captured upvars in the same order as the regular drop code) - rust-lang#89210 (Add missing time complexities to linked_list.rs) - rust-lang#89217 (Enable "generate-link-to-definition" option on rust tools docs as well) - rust-lang#89221 (Give better error for `macro_rules! name!`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 22, 2021
…bank Give better error for `macro_rules name` follow up to rust-lang#89221 r? `@estebank` `@rustbot` modify labels: +A-diagnostics +A-parser
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 22, 2021
…bank Give better error for `macro_rules name` follow up to rust-lang#89221 r? ``@estebank`` ``@rustbot`` modify labels: +A-diagnostics +A-parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @estebank
@rustbot modify labels: +A-diagnostics +A-parser