Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink the CrateStore dynamic interface. #87117

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Shrink the CrateStore dynamic interface. #87117

merged 1 commit into from
Jul 14, 2021

Conversation

cjgillot
Copy link
Contributor

The information is either accessible through queries or by crates which already depend on rustc_metadata.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2021
jyn514
jyn514 reviewed Jul 13, 2021
View reviewed changes
compiler/rustc_middle/src/middle/cstore.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/middle/cstore.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov self-assigned this Jul 14, 2021
@petrochenkov
Copy link
Contributor

r? @petrochenkov
r=me with commits squashed.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2021
@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Jul 14, 2021

📌 Commit 3fba5a4 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 14, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2021
@bors
Auto merge of rust-lang#87133 - GuillaumeGomez:rollup-pfz9jbk, r=Guil…
e87188c 
…laumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#87027 (expand: Support helper attributes for built-in derive macros)
 - rust-lang#87056 (Fix codeblocks overflow)
 - rust-lang#87117 (Shrink the CrateStore dynamic interface.)
 - rust-lang#87120 (rustdoc: Remove unnecessary `extern crate` aliases)
 - rust-lang#87125 (Fix Ayu theme `<code>` color)
 - rust-lang#87130 (Update browser-ui-test package version)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 40155f5 into rust-lang:master Jul 14, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 14, 2021
@cjgillot cjgillot deleted the cstore branch July 15, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@michaelwoerister michaelwoerister michaelwoerister left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
8 participants
@cjgillot @rust-highfive @petrochenkov @bors @michaelwoerister @jyn514 @estebank @rustbot