expand: Support helper attributes for built-in derive macros #87027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Jul 12, 2021
petrochenkov
added
S-waiting-on-author
petrochenkov
force-pushed
the
builderhelp
branch
from
2a2e194 to
6c9ea1e
Compare
|
@bors r=oli-obk |
|
📌 Commit 6c9ea1e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 14, 2021
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#87027 (expand: Support helper attributes for built-in derive macros) - rust-lang#87056 (Fix codeblocks overflow) - rust-lang#87117 (Shrink the CrateStore dynamic interface.) - rust-lang#87120 (rustdoc: Remove unnecessary `extern crate` aliases) - rust-lang#87125 (Fix Ayu theme `<code>` color) - rust-lang#87130 (Update browser-ui-test package version) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for #86735 (derive macro
Defaultshould have a helper attributedefault).With this PR we can specify helper attributes for built-in derives using syntax
#[rustc_builtin_macro(MacroName, attributes(attr1, attr2, ...))]which mirrors equivalent syntax for proc macros#[proc_macro_derive(MacroName, attributes(attr1, attr2, ...))].Otherwise expansion infra was already ready for this.
The attribute parsing code is shared between proc macro derives and built-in macros (
fn parse_macro_name_and_helper_attrs).