Update Clippy #84427
Merged
Update Clippy #84427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick-fix for an ICE in `tabs_in_doc_comments`. The problem was that we we're indexing into possibly multi-byte characters, such as '位'. More specifically `get_chunks_of_tabs` was returning indices into multi-byte characters. Those were passed on to a `Span` creation that then caused the ICE. This fix makes sure that we don't return indices that point inside a multi-byte character. *However*, we are still iterating over unicode codepoints, not grapheme clusters. So a seemingly single character like y̆ , which actually consists of two codepoints, will probably still cause incorrect spans in the output.
Only lint when `into_iter` is an implementation of `IntoIterator` Minor cleanups
Fix `macro_use_import` ICE fixes: rust-lang#7015 changelog: Fix `macro_use_import` ICE
…ffen Invalid null usage v2 This is continuation of rust-lang#6192 after inactivity. I plan to move paths into the compiler as diagnostic items after this is merged. fixes rust-lang#1703 changelog: none
This still applies the lint, and also adds a structured suggestion to rename it.
Use `register_renamed` instead of `register_removed` for uplifted lints This still applies the lint, and also adds a structured suggestion to rename it. changelog: Use `register_renamed` instead of `register_removed` for lints uplifted to rustc
…fn, r=flip1995 Remove `debug_assert` from `panic_in_result_fn` I couldn't find any documentation on `debug_assert` that should be remove. In my humble opinion, I would also like to argue that `todo` and `unreachable` shouldn't trigger this lint? Related: rust-lang/rust-clippy#6082 r? `@flip1995` changelog: Change `panic_in_result_fn` to ignore `debug_assert` and co macros
…arth Fix false-positive `debug_assert` in `panic` This fixes a false-positive in `clippy::panic` when `debug_assert` is used with a message. Fixes rust-lang/rust-clippy#7062. changelog: Fix false-positive in `panic` when `debug_assert` is used with a message
…0, r=giraffate Fix FP in `single_component_path_imports` lint Fix FP in `single_component_path_imports` lint when the import is reused with `self`, like in `use self::module`. Fixes rust-lang#5210 changelog: none
Deprecate `filter_map` Since rust-lang#6591, `filter_map` does not even lint `filter().map()`. The cases that are still linted make no sense IMO. So this just removes/deprecates it. changelog: Deprecate `filter_map` lint Closes rust-lang#3424 Fixes rust-lang#7050
…ishearth Add a note on the issue rust-lang#5953 Hello, I thought it would be better to have a note and warning about this issue considering it introduced an UB in the past even with the "Search on Github" feature. --- changelog: Add a note on the issue rust-lang#5953 to the known problems section.
Introduce `is_lang_ctor` changelog: none Replaces `is_some_ctor` and `is_ok_ctor`. Removes many path usages.
…msteffen add unnecessary_self_imports lint fixes rust-lang#6552 changelog: add `unnecessary_self_imports` lint
Switch transmute_ptr_to_ptr to "pedantic" class. Per discussion in rust-lang/rust-clippy#6372, this lint has significant false positives. changelog: transmute_ptr_to_ptr defaults to "allow".
Rustup r? `@ghost` changelog: none
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
This was referenced Apr 22, 2021
|
@bors r+ |
|
📌 Commit 9482caf has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 24, 2021
Update Clippy r? `@Manishearth` Biweekly Clippy update.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 24, 2021
Update Clippy r? ``@Manishearth`` Biweekly Clippy update.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Apr 24, 2021
Update Clippy r? ```@Manishearth``` Biweekly Clippy update.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Apr 24, 2021
Update Clippy r? ``@Manishearth`` Biweekly Clippy update.
This was referenced Apr 24, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#83519 (Implement a lint that highlights all moves larger than a configured limit) - rust-lang#84105 (stabilize `core::array::{from_ref,from_mut}` in `1.53.0`) - rust-lang#84179 (Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`) - rust-lang#84427 (Update Clippy) - rust-lang#84459 (rustdoc: Turn `JsonRenderer::mod_item_in` into `unreachable!()`) - rust-lang#84460 (rustdoc: Remove unnecessary `is_crate` field from doctree::Module and clean::Module) - rust-lang#84464 (rustdoc: Get rid of `clean::TypeKind`) - rust-lang#84518 (Clean up DOM strings) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
Biweekly Clippy update.