-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] Rename panic_fmt
lint to non_fmt_panic
#81729
Conversation
This comment has been minimized.
This comment has been minimized.
a9c76cc
to
15ff879
Compare
This comment has been minimized.
This comment has been minimized.
15ff879
to
2dfdbe1
Compare
☔ The latest upstream changes (presumably #81761) made this pull request unmergeable. Please resolve the merge conflicts. |
I would like to see this in 1.50, so beta accepting, but looks like there are some conflicts - @m-ou-se could you resolve those? |
If this doesn't get into beta then I think the behavior of doing nothing or silent acceptance etc is fine and doesn't worry me too much. We can always rename the lint without too much hassle IMO. |
2dfdbe1
to
bfa0668
Compare
panic_fmt
lint to non_fmt_panic
panic_fmt
lint to non_fmt_panic
@bors r+ rollup=never |
📌 Commit bfa0668 has been approved by |
⌛ Testing commit bfa0668 with merge 18dc1d220d7db12d529bc1a51fc87cab54e9edf4... |
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry |
@ehuss thanks :) |
[beta] backports This backports: * CI: only copy python.exe to python3.exe if the latter does not exist rust-lang#81762 * Make hitting the recursion limit in projection non-fatal rust-lang#81055 * Remove incorrect `delay_span_bug` rust-lang#81532 * introduce future-compatibility warning for forbidden lint groups rust-lang#81556 * Update cargo rust-lang#81755 * rustdoc: Fix visibility of trait and impl items rust-lang#81288 * Work around missing -dev packages in solaris docker image. rust-lang#81229 * Update LayoutError/LayoutErr stability attributes rust-lang#81767 * Revert 78373 ("dont leak return value after panic in drop") rust-lang#81257 * Rename `panic_fmt` lint to `non_fmt_panic` rust-lang#81729
While extending the recently-added
panic_fmt
lint, we're renaming it tonon_fmt_panic
to follow the lint naming guidelines: #81645The
panic_fmt
lint has not yet reached stable. If we don't do anything,#[allow(panic_fmt)]
will work in 1.50, but give an 'unknown lint' warning in 1.51 later. I'm not sure if this warrants a backport to beta, and if it does, whether it'd be best to just rename the lint (as this PR does) or entirely remove the lint from beta. Opening this PR againstbeta
as a possible option. Feel free to close or suggest a different course of action. :)r? @Mark-Simulacrum