Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Rename panic_fmt lint to non_fmt_panic #81729

Closed
wants to merge 1 commit into from

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Feb 3, 2021

While extending the recently-added panic_fmt lint, we're renaming it to non_fmt_panic to follow the lint naming guidelines: #81645

The panic_fmt lint has not yet reached stable. If we don't do anything, #[allow(panic_fmt)] will work in 1.50, but give an 'unknown lint' warning in 1.51 later. I'm not sure if this warrants a backport to beta, and if it does, whether it'd be best to just rename the lint (as this PR does) or entirely remove the lint from beta. Opening this PR against beta as a possible option. Feel free to close or suggest a different course of action. :)

r? @Mark-Simulacrum

@m-ou-se m-ou-se added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 3, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Feb 5, 2021

☔ The latest upstream changes (presumably #81761) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

I would like to see this in 1.50, so beta accepting, but looks like there are some conflicts - @m-ou-se could you resolve those?

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 5, 2021
@Mark-Simulacrum
Copy link
Member

If this doesn't get into beta then I think the behavior of doing nothing or silent acceptance etc is fine and doesn't worry me too much. We can always rename the lint without too much hassle IMO.

@m-ou-se m-ou-se changed the base branch from master to beta February 5, 2021 08:44
@m-ou-se
Copy link
Member Author

m-ou-se commented Feb 5, 2021

I would like to see this in 1.50, so beta accepting, but looks like there are some conflicts - @m-ou-se could you resolve those?

#81645 (which does the same rename) was merged, hence the conflict. Re-targeted this PR against beta.

@m-ou-se m-ou-se changed the title Rename panic_fmt lint to non_fmt_panic [beta] Rename panic_fmt lint to non_fmt_panic Feb 5, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Feb 5, 2021

📌 Commit bfa0668 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2021
@bors
Copy link
Contributor

bors commented Feb 5, 2021

⌛ Testing commit bfa0668 with merge 18dc1d220d7db12d529bc1a51fc87cab54e9edf4...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  RUST_CONFIGURE_ARGS: --build=i686-pc-windows-gnu
  SCRIPT: make ci-mingw-subset-2
  WIX: /d/a/rust/rust/wix
##[endgroup]
cp: '/c/hostedtoolcache/windows/Python/3.9.1/x64/python.exe' and '/c/hostedtoolcache/windows/Python/3.9.1/x64/python3.exe' are the same file
##[error]Process completed with exit code 1.
[command]"C:\Program Files\Git\bin\git.exe" version
git version 2.30.0.windows.2
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
http.https://github.com/.extraheader
[command]"C:\Program Files\Git\bin\git.exe" config --local --unset-all http.https://github.com/.extraheader
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Cleaning up orphan processes
Terminate orphan process: pid (6464) (node)
Terminate orphan process: pid (7816) (python)
Terminate orphan process: pid (1768) (vctip)

@bors
Copy link
Contributor

bors commented Feb 5, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2021
@m-ou-se
Copy link
Member Author

m-ou-se commented Feb 5, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2021
@ehuss
Copy link
Contributor

ehuss commented Feb 5, 2021

@bors r-

rolling up into #81774

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2021
@ehuss ehuss mentioned this pull request Feb 5, 2021
@m-ou-se
Copy link
Member Author

m-ou-se commented Feb 5, 2021

@ehuss thanks :)

@m-ou-se m-ou-se closed this Feb 5, 2021
@ehuss ehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 5, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2021
[beta] backports

This backports:

* CI: only copy python.exe to python3.exe if the latter does not exist rust-lang#81762
* Make hitting the recursion limit in projection non-fatal rust-lang#81055
* Remove incorrect `delay_span_bug` rust-lang#81532
* introduce future-compatibility warning for forbidden lint groups rust-lang#81556
* Update cargo rust-lang#81755
* rustdoc: Fix visibility of trait and impl items rust-lang#81288
* Work around missing -dev packages in solaris docker image. rust-lang#81229
* Update LayoutError/LayoutErr stability attributes rust-lang#81767
* Revert 78373 ("dont leak return value after panic in drop") rust-lang#81257
* Rename `panic_fmt` lint to `non_fmt_panic` rust-lang#81729
@m-ou-se m-ou-se deleted the fmt-panic-lint-name branch February 6, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants